Skip to content

SF-3745 Do not store or retrieve chapters not requested for drafts#3744

Open
pmachapman wants to merge 2 commits intomasterfrom
fix/SF-3745
Open

SF-3745 Do not store or retrieve chapters not requested for drafts#3744
pmachapman wants to merge 2 commits intomasterfrom
fix/SF-3745

Conversation

@pmachapman
Copy link
Collaborator

@pmachapman pmachapman commented Mar 16, 2026

This PR adds support for partial book drafting by:

  • Only retrieving chapters that are requested in the draft (when chapters are specified)
  • Updating the frontend UI and backend logic to handle scripture ranges that contain chapters (Serval already supports this)

Open with Devin

This change is Reviewable

@pmachapman pmachapman marked this pull request as draft March 16, 2026 23:06
devin-ai-integration[bot]

This comment was marked as resolved.

@codecov
Copy link

codecov bot commented Mar 16, 2026

Codecov Report

❌ Patch coverage is 70.79646% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.28%. Comparing base (a48acd9) to head (c7d7c0d).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...SIL.XForge.Scripture/Services/MachineApiService.cs 63.33% 26 Missing and 7 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3744      +/-   ##
==========================================
- Coverage   81.33%   81.28%   -0.06%     
==========================================
  Files         620      620              
  Lines       39051    39124      +73     
  Branches     6347     6369      +22     
==========================================
+ Hits        31764    31802      +38     
- Misses       6318     6346      +28     
- Partials      969      976       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmachapman pmachapman force-pushed the fix/SF-3745 branch 2 times, most recently from 73c10e4 to 9fc2681 Compare March 16, 2026 23:58
@pmachapman pmachapman changed the title WIP: SF-3745 Do not store or retrieve chapters not requested for drafts SF-3745 Do not store or retrieve chapters not requested for drafts Mar 17, 2026
@pmachapman pmachapman added the will require testing PR should not be merged until testers confirm testing is complete label Mar 17, 2026
@pmachapman pmachapman marked this pull request as ready for review March 17, 2026 01:12
Copy link

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 0 new potential issues.

View 8 additional findings in Devin Review.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

will require testing PR should not be merged until testers confirm testing is complete

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant