SF-3542 Do not allow cut operations across multiple segments#3745
Merged
pmachapman merged 1 commit intomasterfrom Mar 22, 2026
Merged
SF-3542 Do not allow cut operations across multiple segments#3745pmachapman merged 1 commit intomasterfrom
pmachapman merged 1 commit intomasterfrom
Conversation
pmachapman
added
the
will require testing
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3745 +/- ##
==========================================
- Coverage 81.31% 81.31% -0.01%
==========================================
Files 620 620
Lines 39079 39080 +1
Branches 6352 6352
==========================================
Hits 31778 31778
- Misses 6329 6330 +1
Partials 972 972 ☔ View full report in Codecov by Sentry. |
RaymondLuong3
approved these changes
Mar 19, 2026
Collaborator
RaymondLuong3
left a comment
RaymondLuong3
left a comment
There was a problem hiding this comment.
Works well in my testing. Glad to see we could reuse code for this fix.
@RaymondLuong3 reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on pmachapman).
pmachapman
added
testing complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a segment removal bug when selecting more than one segment, then attempting to cut the text, which can result in verse numbers disappearing.
This change is