Skip to content

Retire NT drafting notice after 90 days#3747

Merged
pmachapman merged 1 commit intomasterfrom
feature/retire-nt-drafting-notice-after-90-days
Mar 18, 2026
Merged

Retire NT drafting notice after 90 days#3747
pmachapman merged 1 commit intomasterfrom
feature/retire-nt-drafting-notice-after-90-days

Conversation

@Nateowami
Copy link
Copy Markdown
Collaborator

@Nateowami Nateowami commented Mar 18, 2026

This should have been included when the notice originally was created, but I'm not sure if we'd decided how long it would be up at the time. The latest decision is for 90 days.

Hard-coding an EOL for a notice is something we've done before and:

  • Prevents us from forgetting to remove it
  • Documents how long it is intended to remain

Open with Devin

This change is Reviewable

Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.31%. Comparing base (6a27b10) to head (845b0d2).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3747   +/-   ##
=======================================
  Coverage   81.31%   81.31%           
=======================================
  Files         620      620           
  Lines       39075    39076    +1     
  Branches     6351     6370   +19     
=======================================
+ Hits        31774    31775    +1     
+ Misses       6329     6316   -13     
- Partials      972      985   +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmachapman pmachapman force-pushed the feature/retire-nt-drafting-notice-after-90-days branch from 3e43c30 to 845b0d2 Compare March 18, 2026 18:16
@pmachapman pmachapman self-assigned this Mar 18, 2026
Copy link
Copy Markdown
Collaborator

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@pmachapman reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Nateowami).

@pmachapman pmachapman enabled auto-merge (squash) March 18, 2026 18:24
@pmachapman pmachapman merged commit 0fe8055 into master Mar 18, 2026
22 checks passed
@pmachapman pmachapman deleted the feature/retire-nt-drafting-notice-after-90-days branch March 18, 2026 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants