agent: create user with option to enable client service #1684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epoberezkin
force-pushed
the
ep/service-create-user
branch
from
8068b8d to
5444e05
Compare
epoberezkin
commented
Dec 27, 2025
| reqTimeout `timeout` ((Right <$> sendReq req process) `E.catches` httpClientHandlers) >>= \case | ||
| Just (Right r) -> pure $ Right r | ||
| Just (Left (e :: E.SomeException)) -> disconnected $> Left (HCIOError $ E.displayException e) | ||
| Just (Left e) -> disconnected $> Left e |
Member
Author
There was a problem hiding this comment.
Catching SomeException that previously replaced IOException results in undesirable catching of async exceptions.
We need to review all catch, try etc. from Control.Exceptions and use safe alternatives that don't catch async exceptions. catchAllErrors etc. are already safe as they use UnliftIO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.