test(secrets): preserve standard tool permissions

Author: icecrasher321

apps/sim/lib/copilot/request/tools/permission.test.ts

@@ -94,6 +94,18 @@ describe('toolCallNeedsApproval', () => {
     expect(toolCallNeedsApproval('terminal', context, {}, false, runCall)).toBe(false)
   })
 
+  it('applies the normal saved permission to code with a secret reference', () => {
+    const context = makeContext()
+    context.toolPermissions.autoAllowed.add('function_execute')
+
+    expect(
+      toolCallNeedsApproval('function_execute', context, {}, false, {
+        language: 'javascript',
+        code: 'return {{API_KEY}}',
+      })
+    ).toBe(false)
+  })
+
   it('never gates a non-interactive run, which has nobody to answer the prompt', () => {
     expect(
       toolCallNeedsApproval('terminal', makeContext(), { interactive: false }, false, runCall)
@@ -106,6 +118,18 @@ describe('toolCallNeedsApproval', () => {
     expect(toolCallNeedsApproval('terminal', context, {}, false, runCall)).toBe(false)
   })
 
+  it('does not add a secret-specific gate when the permission feature is off', () => {
+    const context = makeContext()
+    context.toolPermissions.enabled = false
+
+    expect(
+      toolCallNeedsApproval('function_execute', context, {}, false, {
+        language: 'javascript',
+        code: 'return {{API_KEY}}',
+      })
+    ).toBe(false)
+  })
+
   it('gates a resolved integration operation off the frame Go stamped', () => {
     // gmail_read_v2 is request-local: it is not in the catalog at all, so the
     // only thing marking it is the awaiting_approval status on the frame.
@@ -284,6 +308,23 @@ describe('runGatedToolExecution', () => {
     expect(context.toolPermissions.autoAllowed.has('terminal')).toBe(true)
   })
 
+  it('accepts the normal chat-level decision for code with a secret reference', async () => {
+    const context = makeContext()
+    const toolCall = makeToolCall()
+    toolCall.name = 'function_execute'
+    toolCall.params = { language: 'javascript', code: 'return {{API_KEY}}' }
+    const execute = vi.fn().mockResolvedValue({ status: 'success' })
+    waitForToolPermissionDecision.mockResolvedValue({
+      toolCallId: 'call-1',
+      decision: 'allow_chat',
+    })
+
+    await gate(context, toolCall, execute, [])
+
+    expect(execute).toHaveBeenCalledTimes(1)
+    expect(context.toolPermissions.autoAllowed.has('function_execute')).toBe(true)
+  })
+
   it('does not suppress later prompts for a one-off allow', async () => {
     const context = makeContext()
     const toolCall = makeToolCall()