perf(tests): skip jest-dom in node-environment test files

[waleedlatif1]

Summary

Lint and Test is now the CI critical path (184s vs Build App's 147s after #6080), and 143s of that 184s is the test suite. This takes ~8% off it.

vitest.setup.ts loaded @testing-library/jest-dom/vitest unconditionally, so all 1,219 test files paid for it. jest-dom only registers DOM matchers (toBeInTheDocument, toBeVisible, …), which are useless without a document — and 985 of those files declare @vitest-environment node.

Where the time actually goes

From the CI run's own vitest summary (aggregate across workers, so it exceeds wall clock):

Duration 141.02s (transform 101.32s, setup 123.76s, import 686.00s, tests 55.18s, environment 15.07s)

Actual test execution is 55s. The rest is per-file overhead — and setup is the part a global setup file controls.

Measured, same machine, full suite

	Duration	setup (aggregate)
baseline	179.47s	367.13s
guarded	165.78s	252.72s

7.6% off the suite, 31% off aggregate setup. On a node-only subset (50 files, n=3 each) it's 21% — 2.75s → 2.16s median.

Nothing loses a matcher

All 7 files that actually call a jest-dom matcher are explicitly @vitest-environment jsdom, so typeof document !== 'undefined' is true for exactly those. Verified by running them: 4 files / 7 tests pass.

Full suite is identical either way — 1225 files / 16184 tests pass. The one failure (cloud-review-tools.test.ts) reproduces on unmodified staging: its spawned python3 can't find rg on macOS. CI installs ripgrep explicitly and it passes there.

Two CI docs that claimed more than the code does

Same class as #6076, found while tracing this:

• The step was named "Run tests with coverage" but runs bun run test = vitest run, with no --coverage anywhere.
• The Codecov upload reads apps/sim/coverage, which nothing generates — vitest.config.ts declares no coverage provider. It uploads nothing and still reports success in ~1s because fail_ci_if_error: false. So its green tick has never meant coverage was published.

I annotated rather than deleted the Codecov step: @vitest/coverage-v8 is installed, so enabling coverage is possible, but instrumentation costs test time and nothing gates on the result. That's a call for you, not a side effect of a perf change — happy to either wire it up or drop the step.

Not addressed here

import is the real monster — 686s aggregate vs 55s of actual tests. That's module graph cost per test file, the same root cause as the tool registry being 68–78% of every route's graph. vitest.setup.ts already globally mocks @/blocks/registry; doing the same for @/tools/registry could be large, but it would silently change behaviour for any test that needs real tools, across 1,219 files. Needs its own measured, scoped change.

Type of Change

• Performance
• Improvement (CI documentation accuracy)

Testing

Full suite run both ways on the same machine (numbers above); the 7 jest-dom-dependent files run explicitly; actionlint clean; biome clean.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
docs	Building	Preview	Jul 30, 2026 3:14am

[cursor]

PR Summary

Low Risk
Test-only setup and CI comment/name changes; no production or auth paths touched.

Overview
vitest.setup.ts now loads @testing-library/jest-dom/vitest only when document exists, so ~985 @vitest-environment node files no longer pay jest-dom setup cost; jsdom tests that use DOM matchers keep the same behavior.

CI docs in .github/workflows/test-build.yml are aligned with what actually runs: the test step is renamed from “with coverage” to Run tests (plain vitest run), and comments explain that the Codecov step points at apps/sim/coverage that nothing generates today—the step is left in place pending enable-or-remove coverage.

^{Reviewed by Cursor Bugbot for commit 264dcef. Configure here.}

[greptile-apps]

Greptile Summary

Conditionally loads jest-dom only when a DOM document exists so node-environment Vitest files skip that setup cost, and clarifies CI step naming/comments around tests and the unused Codecov path.

• vitest.setup.ts: gate @testing-library/jest-dom/vitest behind typeof document !== 'undefined' via dynamic import
• test-build.yml: rename “Run tests with coverage” → “Run tests”; document that Codecov uploads nothing today without changing commands or action inputs

Confidence Score: 5/5

Safe to merge; no blocking defects in the guarded jest-dom load or the CI annotation-only workflow edits.

Default environment is node, matcher-using tests are jsdom-annotated so the document guard still loads jest-dom there, Vitest 4 setupFiles support the top-level await pattern, and the workflow change does not alter run commands or referenced step contracts.

Important Files Changed

Filename	Overview
apps/sim/vitest.setup.ts	Skips jest-dom registration in the default node environment; jsdom tests still load matchers when document is present.
.github/workflows/test-build.yml	Cosmetic step rename and dead-path Codecov comments; test command and Codecov action inputs unchanged.

_{Reviews (1): Last reviewed commit: "perf(tests): skip jest-dom in node-envir..." | Re-trigger Greptile}