Skip to content

fix(slack): use runtime origin for onboarding links - #7690

Merged
TheodoreSpeaks merged 1 commit into
stagingfrom
codex/slack-onboarding-runtime-url
Sep 9, 2026
Merged

fix(slack): use runtime origin for onboarding links#7690
TheodoreSpeaks merged 1 commit into
stagingfrom
codex/slack-onboarding-runtime-url

Conversation

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator

Summary

  • Use the runtime public URL for Slack onboarding buttons and the matching links saved in Sim chat history. Shared builds now use the deployment origin instead of retaining the build-time localhost default.
  • Add regression coverage for different runtime origins and missing configuration. Previously sent messages keep their saved links.

Type of Change

  • Bug fix

Testing

  • Reproduced the incorrect URL with regression tests before applying the fix.
  • 266 focused tests across 23 suites passed, along with app/auth typechecks, lint, all 46 repository audits, block-registry and docs-manifest checks.
  • No live Slack smoke test or deployment performed.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 9, 2026 10:07pm UTC

Request Review

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@greptile

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete.

@greptile-apps

greptile-apps Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR updates Slack onboarding links to use the runtime public application URL rather than the statically imported environment value.

  • Routes onboarding buttons through the existing normalized getBaseUrl() utility.
  • Adds regression coverage for multiple deployment origins and missing runtime configuration.
  • Preserves already-generated links by changing only link creation for new onboarding messages.

Confidence Score: 5/5

The PR appears safe to merge, with the runtime URL behavior covered by focused regression tests and no actionable failures identified.

The production caller runs server-side, where getBaseUrl() reads the runtime environment expected by supported deployments; it consistently supplies the same generated URL to Slack and persisted message data, and missing configuration already failed under the previous implementation.

Important Files Changed

Filename Overview
apps/sim/lib/slack-search/onboarding.ts Replaces the direct environment base URL with the runtime-aware, normalized application URL utility.
apps/sim/lib/slack-search/onboarding.test.ts Verifies runtime-origin selection and explicit failure when the public URL is unavailable.

Reviews (1): Last reviewed commit: "fix(slack): use runtime origin for onboa..." | Re-trigger Greptile

@TheodoreSpeaks
TheodoreSpeaks merged commit bfa61f3 into staging Sep 9, 2026
33 checks passed
@TheodoreSpeaks
TheodoreSpeaks deleted the codex/slack-onboarding-runtime-url branch September 9, 2026 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant