feat: setup vitest browser mode by noahluftyang · Pull Request #174 · sipe-team/side

noahluftyang · 2025-06-06T04:38:48Z

Changes

add global config for using vitest browser mode
refactor template codes
- set vitest browser mode as default testing environment
- use vanilla-extract for styling

Visuals

Checklist

Have you written the functional specifications?
Have you written the test code?

Additional Discussion Points

changeset-bot · 2025-06-06T04:38:52Z

⚠️ No Changeset found

Latest commit: ab27ab1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

netlify · 2025-06-06T04:38:53Z

✅ Deploy Preview for side-design-system ready!

Name	Link
🔨 Latest commit	`ab27ab1`
🔍 Latest deploy log	https://app.netlify.com/projects/side-design-system/deploys/684e60a74378d00008c3ee12
😎 Deploy Preview	https://deploy-preview-174--side-design-system.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

coderabbitai · 2025-06-06T04:38:54Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2025-06-06T04:40:38Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

froggy1014

코멘트 한번만 확인해주세요 ~ !

froggy1014 · 2025-06-06T14:27:51Z

pnpm-workspace.yaml

-  vitest: ^2.1.8
+  vite: ^6.3.5
+  vitest: ^3.1.3
+  vitest-browser-react: ^0.1.1


별거 아니긴한데, vitest-browser-react 패키지 한번 보니까, 0.2.0 버전까지 배포됬는데 호환때문에 0.1.1로 설정 해놓으신건가요 ~ ?

버전업도 따로 챙겨볼게~

froggy1014 · 2025-06-06T14:39:11Z

.templates/component/vitest.config.ts

+      browser: {
+        enabled: true,
+        headless: true,
+        provider: 'playwright',
+        instances: [{ browser: 'chromium' }],
+      },


viteest 3 버전부터는 vitest.workspace..ts가 deprecated되서, vite.config.ts에 projects 넣어주시면 될 것 같아요.

https://vitest.dev/guide/projects

Suggested change

browser: {

enabled: true,

headless: true,

provider: 'playwright',

instances: [{ browser: 'chromium' }],

},

browser: {

enabled: true,

headless: true,

provider: 'playwright',

instances: [{ browser: 'chromium' }],

},

projects: ['packages/*'],

이것도 실제로 패키지에 적용할 때 챙겨볼게 ㅎㅎ browser mode를 쓸 때 projects에 선언하는거랑 vitest.workspace.ts 파일에 선언하는거랑 동작이 살짝 달랐던걸로 기억해서.. 😭

noahluftyang requested review from dev-hobin, froggy1014, haedawn, jiji-hoon96, leejiwonn and synuns as code owners June 6, 2025 04:38

auto-assign bot assigned noahluftyang Jun 6, 2025

froggy1014 approved these changes Jun 6, 2025

View reviewed changes

froggy1014 linked an issue Jun 6, 2025 that may be closed by this pull request

[FEATURE] 테스트를 browser mode로 실행하도록 변경 #141

Open

jiji-hoon96 approved these changes Jun 6, 2025

View reviewed changes

froggy1014 mentioned this pull request Jun 6, 2025

refactor: use vitest browser mode #155

Closed

2 tasks

feat: setup vitest browser mode base configurations

ab27ab1

noahluftyang force-pushed the fix/setup-vitest-browser-mode branch from 1d0cca5 to ab27ab1 Compare June 15, 2025 05:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: setup vitest browser mode#174

feat: setup vitest browser mode#174
noahluftyang wants to merge 1 commit intorelease/v1from
fix/setup-vitest-browser-mode

noahluftyang commented Jun 6, 2025

Uh oh!

changeset-bot bot commented Jun 6, 2025 •

edited

Loading

Uh oh!

netlify bot commented Jun 6, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Jun 6, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

codecov bot commented Jun 6, 2025 •

edited

Loading

Uh oh!

froggy1014 left a comment

Uh oh!

froggy1014 Jun 6, 2025

Uh oh!

noahluftyang Jun 15, 2025

Uh oh!

froggy1014 Jun 6, 2025

Uh oh!

noahluftyang Jun 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

noahluftyang commented Jun 6, 2025

Changes

Visuals

Checklist

Additional Discussion Points

Uh oh!

changeset-bot bot commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

netlify bot commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for side-design-system ready!

Uh oh!

coderabbitai bot commented Jun 6, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

codecov bot commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

froggy1014 left a comment

Choose a reason for hiding this comment

Uh oh!

froggy1014 Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

noahluftyang Jun 15, 2025

Choose a reason for hiding this comment

Uh oh!

froggy1014 Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

noahluftyang Jun 15, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

changeset-bot bot commented Jun 6, 2025 •

edited

Loading

netlify bot commented Jun 6, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Jun 6, 2025 •

edited

Loading