Skip to content

from_altaz(...) does not fully populate the resultant object. #1085

Open

Description

@bryan-lunt

The function from_altaz creates an object lacking a center and a time, however, it has to start with a position and a time, so it seems like it should / could have those fields populated?

def from_altaz(self, alt=None, az=None, alt_degrees=None, az_degrees=None,

I'm sorry I'm not explaining it well, I've been up all night.

Activity

  1. bryan-lunt commented on Jun 9, 2025

    @bryan-lunt
    Author

    Here's my code that is using this. Maybe it will make it more clear.

    https://github.com/bryan-lunt/celestial_navigation_homework/blob/061fb49eb0cfa2043934dfacbddd2cbbf2cd3fbb/navhw/__init__.py#L46

        sun_lower_limb_apparent.center = observer_location; sun_lower_limb_apparent.t = observed_time
    
  2. brandon-rhodes commented on Jun 27, 2025

    @brandon-rhodes
    Member

    Your link has disappeared over the past few weeks, but, even without seeing the example code, I can imagine how the Apparent position will get updated. I think it's quite reasonable that we would set the .center and .t for the user instead of them having to do it themselves, so I'll plan to add it to the next version of Skyfield.

  3. bryan-lunt commented on Jul 19, 2025

    @bryan-lunt
    Author

    Thank you!

    Sorry, I did not realize that my project is still private when I posted the link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions