Repository navigation
Make all references to geometric points conform to standards #30
Description
See: https://github.com/skytreader/PyGame-Objects/wiki/Standards-and-Conventions
Make it so that all tuples describing positions describe them as (row, col). draw_offset currently uses (width, height) and is confusing.
Activity
skytreader commentedon Feb 27, 2018
On the other hand, check with pygame conventions and conform to that: https://www.pygame.org/docs/ref/draw.html#pygame.draw.line
Looks like
pygame.draw.lineexpects points in the actual (x, y) format; column indices go first before row indices.Happy test passes.
skytreader commentedon Mar 17, 2018
More notes on PyGame conventions: font.size returns
(width, height).[-]draw_offset is inconsistent[/-][+]Make all references to geometric points conform to standards[/+]Make Drawable (and children) conform to geometric points standard.
Saner indexing for geometric points.
skytreader commentedon Apr 11, 2018
Violation: Docstring for
Drawableconstructor says thatdraw_offsetis a(width, height)tuple butGameScreen._is_drawable_clickeduses index 1 for width and index 0 for height.First tests for _is_drawable_clicked.
Make it so that draw_offset is (row, col), not (width, height).