-
Notifications
You must be signed in to change notification settings - Fork 228
feat: add workflow.featured.{add|list|remove|set} methods #1542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1542 +/- ##
============================================
+ Coverage 72.98% 73.28% +0.30%
- Complexity 4476 4511 +35
============================================
Files 477 477
Lines 14223 14266 +43
Branches 1483 1487 +4
============================================
+ Hits 10380 10455 +75
+ Misses 2964 2919 -45
- Partials 879 892 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🧪 Testing steps import com.slack.api.Slack;
import com.slack.api.methods.SlackApiException;
import com.slack.api.methods.response.workflows.WorkflowsFeaturedAddResponse;
import com.slack.api.methods.response.workflows.WorkflowsFeaturedListResponse;
import com.slack.api.methods.response.workflows.WorkflowsFeaturedRemoveResponse;
import com.slack.api.methods.response.workflows.WorkflowsFeaturedSetResponse;
import java.util.List;
Slack slack = Slack.getInstance();
String token = System.getenv("SLACK_BOT_TOKEN");
WorkflowsFeaturedAddResponse add = slack.methods(token)
.workflowsFeaturedAdd(req -> req.channelId("C04CRUE6MU3").triggerIds(List.of("Ft07BVE8UHEK", "Ft0A4EDARZL6")));
System.out.println(add);
WorkflowsFeaturedListResponse list = slack.methods(token)
.workflowsFeaturedList(req -> req.channelIds(List.of("C04CRUE6MU3")));
System.out.println(list);
WorkflowsFeaturedRemoveResponse remove = slack.methods(token)
.workflowsFeaturedRemove(req -> req.channelId("C04CRUE6MU3").triggerIds(List.of("Ft07BVE8UHEK")));
System.out.println(remove);
WorkflowsFeaturedSetResponse set = slack.methods(token)
.workflowsFeaturedSet(req -> req.channelId("C04CRUE6MU3").triggerIds(List.of("Ft0A4EDARZL6", "Ft07BVE8UHEK")));
System.out.println(set); |
zimeg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@srtaalej LGTM! Thanks so much for featuring these methods 🙏 ✨
I left a few comments but nothing is blocking IMHO. Some are related to testing and I was curious if a bot token was working for you? I found a restricted_action error so I had to use a user token.
...lient/src/main/java/com/slack/api/methods/request/workflows/WorkflowsFeaturedAddRequest.java
Outdated
Show resolved
Hide resolved
...nt/src/main/java/com/slack/api/methods/request/workflows/WorkflowsFeaturedRemoveRequest.java
Outdated
Show resolved
Hide resolved
slack-api-client/src/test/java/test_with_remote_apis/methods/workflows_Test.java
Show resolved
Hide resolved
slack-api-client/src/test/java/test_locally/api/methods/WorkflowsTest.java
Show resolved
Hide resolved
…orkflows/WorkflowsFeaturedAddRequest.java Co-authored-by: Eden Zimbelman <[email protected]>
…orkflows/WorkflowsFeaturedRemoveRequest.java Co-authored-by: Eden Zimbelman <[email protected]>
This PR adds missing
workflow.featuredmethodsadd, list, remove, setTesting:
Category (place an
xin each of the[ ])Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.