Repository navigation
Conversation
🦋 Changeset detectedLatest commit: 1d570ba The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thanks for the contribution! Before we can merge this, we need @kimoto to sign the Salesforce Inc. Contributor License Agreement. |
kimoto
changed the title
files.uploadV2 sent image alt text to files.getUploadURLExternal as alt_text, which Slack ignores. Send it as alt_txt. The request type gains alt_txt and keeps alt_text as deprecated so existing code compiles. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kimoto
force-pushed
the
fix/upload-alt-txt
branch
from
October 22, 2026 21:20
7aca268 to
1d570ba
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2788.
Alt text passed to
files.uploadV2was not saved by Slack. The SDK sent it tofiles.getUploadURLExternalasalt_text, but Slack reads onlyalt_txt(docs) and silently ignoresalt_text. This PR sends it under the name Slack reads. TheuploadV2option keeps its name, so callers do not need to change anything.FilesGetUploadURLExternalArgumentsgainsalt_txtand keepsalt_textas@deprecatedfor backward compatibility, so existing code that passes it still compiles.Checked by: the multi-file upload test, which now passes alt text; and uploads to a real workspace, where only this branch's image got
alt_txtinfiles.infoand the ALT badge on hover.Before (published 8.2.0):
After (this branch):
Requirements