Skip to content

fix(python): output a warning for .venv activation errors#368

Merged
mwbrooks merged 2 commits intomainfrom
mwbrooks-venv-error-warning
Mar 9, 2026
Merged

fix(python): output a warning for .venv activation errors#368
mwbrooks merged 2 commits intomainfrom
mwbrooks-venv-error-warning

Conversation

@mwbrooks
Copy link
Member

@mwbrooks mwbrooks commented Mar 7, 2026

Changelog

Output a warning instead of an error when activating the Python virtual environment (.venv/) fails.

Summary

This pull request updates the Python virtual environment (.venv/) activation issues to be output as warnings.

Related to feedback: #347 (comment)

Requirements

@mwbrooks mwbrooks requested a review from a team as a code owner March 7, 2026 00:31
@codecov
Copy link

codecov bot commented Mar 7, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 65.22%. Comparing base (017f8d3) to head (b6013a4).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/shared/clients.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #368      +/-   ##
==========================================
- Coverage   65.25%   65.22%   -0.03%     
==========================================
  Files         216      216              
  Lines       17991    17991              
==========================================
- Hits        11740    11735       -5     
- Misses       5160     5163       +3     
- Partials     1091     1093       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mwbrooks mwbrooks changed the title fix: surface venv activation errors as warnings fix(python): output a warning for .venv activation errors Mar 7, 2026
@mwbrooks mwbrooks self-assigned this Mar 7, 2026
@mwbrooks mwbrooks added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch Use on pull requests to describe the release version increment area:bolt-python Related to github.com/slackapi/bolt-python labels Mar 7, 2026
@mwbrooks mwbrooks added this to the Next Release milestone Mar 7, 2026
@mwbrooks mwbrooks added the changelog Use on updates to be included in the release notes label Mar 7, 2026
Copy link
Member

@zimeg zimeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ @mwbrooks Praise once more! Making problems known makes these quick to be addressed in troubleshooting! Amazing change!

@mwbrooks
Copy link
Member Author

mwbrooks commented Mar 9, 2026

@zimeg Thanks for the review! 🙇🏻 Lots of credit goes to you for suggesting the change! 😸

@mwbrooks mwbrooks merged commit 4973cd6 into main Mar 9, 2026
7 checks passed
@mwbrooks mwbrooks deleted the mwbrooks-venv-error-warning branch March 9, 2026 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:bolt-python Related to github.com/slackapi/bolt-python bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented changelog Use on updates to be included in the release notes semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants