This repository was archived by the owner on Oct 30, 2018. It is now read-only.
Increase SLKTextView's influence over calculating its height.#653
Open
lukkas wants to merge 3 commits intoslackhq:masterfrom
lukkas:master
Open
Increase SLKTextView's influence over calculating its height.#653lukkas wants to merge 3 commits intoslackhq:masterfrom lukkas:master
lukkas wants to merge 3 commits intoslackhq:masterfrom
lukkas:master
Conversation
dzenbot
approved these changes
Aug 17, 2018
dzenbot
left a comment
There was a problem hiding this comment.
LGTM but please update the recent conflict.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Change doesn't affect the functionality in any way. It moves SLKTextView height calculation logic to SLKTextView class itself. This adds flexibility when subclassing SLKTextView.
Example:
When adding custom line spacing using NSAttributedString and NSParagraphStyle to text in text view, there is currently no way to change its height in order to accommodate text formatted that way.