Skip to content

Implement search command#293

Merged
maraino merged 5 commits intomainfrom
mariano/search
Feb 25, 2026
Merged

Implement search command#293
maraino merged 5 commits intomainfrom
mariano/search

Conversation

@maraino
Copy link
Contributor

@maraino maraino commented Jan 9, 2026

This commit adds the search command to step-kms-plugin. With this command we will be able to search keys on those KMS that support the SearchKeys method, currently mackms and tpmkms.

Requires:

This commit adds the search command to step-kms-plugin. With this
command we will be able to search keys on those KMS that support the
SearchKeys method, currently mackms and tpmkms.
@maraino maraino marked this pull request as ready for review January 21, 2026 20:09
@maraino maraino requested a review from a team as a code owner January 21, 2026 20:09
@maraino maraino requested a review from hslatman January 21, 2026 20:09
cmd/search.go Outdated
Comment on lines 8 to 12
"github.com/smallstep/step-kms-plugin/internal/flagutil"
"github.com/spf13/cobra"
"go.step.sm/crypto/kms/apiv1"
"go.step.sm/crypto/pemutil"
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"github.com/smallstep/step-kms-plugin/internal/flagutil"
"github.com/spf13/cobra"
"go.step.sm/crypto/kms/apiv1"
"go.step.sm/crypto/pemutil"
)
"github.com/spf13/cobra"
"go.step.sm/crypto/kms/apiv1"
"go.step.sm/crypto/pemutil"
"github.com/smallstep/step-kms-plugin/internal/flagutil"
)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed with 85a3560


fmt:
$Q goimports --local github.com/smallstep/step-kms-plugin -l -w $(SRC)
$Q goimports --local github.com/smallstep/step-kms-plugin --local go.step.sm/crypto -l -w $(SRC)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@maraino maraino merged commit 0bbb39e into main Feb 25, 2026
14 checks passed
@maraino maraino deleted the mariano/search branch February 25, 2026 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants