Closed
Conversation
* Fee Quoter changes to support ton and aptos * add tests for other families * Add tests for all remote chain selectors
* Bump versios * Bump all contracts
|
agusaldasoro
changed the base branch from
main
to
solana-contracts/v1.6.1-candidate
|
|
|
agusaldasoro
commented
Feb 24, 2026
| ocr3_config.config_info.config_digest = cfg.config_digest; | ||
|
|
||
| emit!(ConfigSet { | ||
| emit!(Ocr3ConfigSet { |
Contributor
Author
There was a problem hiding this comment.
Undo this: no breaking changes on the event names
| #[cfg(feature = "idl-build")] | ||
| /// CHECK: Runtime uses dynamic seeds from parsed report | ||
| #[account(mut)] | ||
| pub source_chain: UncheckedAccount<'info>, |
Contributor
Author
There was a problem hiding this comment.
Can this be a SourceChain Account? Instead of unchecked
| #[derive(Clone, AnchorSerialize, AnchorDeserialize)] | ||
| pub struct Ocr3ConfigInfoInput { | ||
| pub config_digest: [u8; 32], | ||
| pub f: u8, |
Contributor
Author
There was a problem hiding this comment.
This is missing n and is_signature_verification_enabled params
toblich
force-pushed
the
solana-contracts/v1.6.1-candidate
branch
from
f1f0482 to
10b851b
Compare
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| return fmt.Errorf("account index %d for %s is out of bounds (max: %d)", indices[indexOffset], "authority", len(accountKeys)-1) | ||
| } | ||
| obj.Authority = accountKeys[indices[indexOffset]] | ||
| indexOffset++ |
| return fmt.Errorf("account index %d for %s is out of bounds (max: %d)", indices[indexOffset], "address", len(accountKeys)-1) | ||
| } | ||
| obj.Address = accountKeys[indices[indexOffset]] | ||
| indexOffset++ |
| return fmt.Errorf("account index %d for %s is out of bounds (max: %d)", indices[indexOffset], "owner", len(accountKeys)-1) | ||
| } | ||
| obj.Owner = accountKeys[indices[indexOffset]] | ||
| indexOffset++ |
| return fmt.Errorf("account index %d for %s is out of bounds (max: %d)", indices[indexOffset], "address", len(accountKeys)-1) | ||
| } | ||
| obj.Address = accountKeys[indices[indexOffset]] | ||
| indexOffset++ |
| return fmt.Errorf("account index %d for %s is out of bounds (max: %d)", indices[indexOffset], "authority", len(accountKeys)-1) | ||
| } | ||
| obj.Authority = accountKeys[indices[indexOffset]] | ||
| indexOffset++ |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.