Conversation
…w-drain-period-when-stopping-service
0xAustinWang
reviewed
Mar 2, 2026
0xAustinWang
reviewed
Mar 2, 2026
| for { | ||
| select { | ||
| case request := <-aggregationChannel: | ||
| submitWork(request) |
Contributor
There was a problem hiding this comment.
A bit weird to receive on the aggregationChannel here as well as line 210.
Is there a way to perform the cleanup on the aggregationChannel level? IE close the aggregationChannel after drainPeriod and then use that as a signal to clean up on the worker level.
Alternatively, can we create the go func() { waitDone <- p.Wait() }() inside StartBackground?
|
Code coverage report:
|
0xAustinWang
reviewed
Mar 2, 2026
| for _, key := range m.clientOrder { | ||
| ch := m.clientChannel[key] | ||
| if len(ch) > 0 { | ||
| m.AggregationChannel <- <-ch |
0xAustinWang
approved these changes
Mar 2, 2026
carte7000
deleted the
simon/aggregator/allow-drain-period-when-stopping-service
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ator