Add confidential-workflows capability codegen#1851
Conversation
Generated Go types and server from the new confidential-workflows proto in chainlink-protos. Types: SecretIdentifier, WorkflowExecution, ConfidentialWorkflowRequest, ConfidentialWorkflowResponse. Server implements ClientCapability interface with Execute method.
|
👋 nadahalli, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
nadahalli
temporarily deployed
to
integration
GitHub Actions
Inactive
nadahalli
had a problem deploying
to
integration
GitHub Actions
Failure
nadahalli
temporarily deployed
to
integration
GitHub Actions
Inactive
✅ API Diff Results - No breaking changes |
There was a problem hiding this comment.
Pull request overview
This PR adds code generation for the confidential-workflows@1.0.0-alpha capability, which enables confidential workflow execution with secret management from VaultDON. The generated code provides the type definitions and server scaffolding needed to implement this capability in the chainlink ecosystem.
Changes:
- Generated Go protobuf types (
SecretIdentifier,WorkflowExecution,ConfidentialWorkflowRequest,ConfidentialWorkflowResponse) from the proto definition - Generated server scaffolding implementing the capability interface pattern used throughout the codebase
- Updated chainlink-protos/cre/go dependency to include the new capability proto definition
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/capabilities/v2/actions/confidentialworkflow/client.pb.go | Generated protobuf types for confidential workflow requests, responses, and related data structures |
| pkg/capabilities/v2/actions/confidentialworkflow/server/client_server_gen.go | Generated server scaffolding providing ClientCapability interface and implementation for the confidential-workflows capability |
| pkg/capabilities/v2/actions/confidentialworkflow/generate.go | Code generation directive to generate from capabilities/compute/confidentialworkflow/v1alpha/client.proto |
| go.mod | Updated chainlink-protos/cre/go dependency version to include confidential workflow proto definitions |
| go.sum | Updated checksums for the new chainlink-protos/cre/go dependency version |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Implementation plan: Confidential CRE Workflows (full PR chain and cross-repo dependencies) |
Removes owner field from SecretIdentifier per reviewer feedback.
nadahalli
had a problem deploying
to
integration
GitHub Actions
Error
nadahalli
had a problem deploying
to
integration
GitHub Actions
Error
nadahalli
had a problem deploying
to
integration
GitHub Actions
Error
nadahalli
had a problem deploying
to
integration
GitHub Actions
Error
nadahalli
had a problem deploying
to
integration
GitHub Actions
Error
nadahalli
had a problem deploying
to
integration
GitHub Actions
Error
nadahalli
temporarily deployed
to
integration
GitHub Actions
Inactive
nadahalli
temporarily deployed
to
integration
GitHub Actions
Inactive
nadahalli
temporarily deployed
to
integration
GitHub Actions
Inactive
✅ API Diff Results -
|
Shared JSON-RPC wire types for the enclave <-> relay DON protocol, enabling both confidential-compute and chainlink to use the same struct definitions.
Avoid exposing "enclave" as an implementation detail in the public API surface. Also update method/domain prefixes from "enclave." to "confidential.".
Summary
confidential-workflows@1.0.0-alphacapability protocre/capabilities/compute/confidentialworkflow/v1alpha/client.protoin chainlink-protosConfidentialWorkflowRequest,ConfidentialWorkflowResponse,SecretIdentifier,WorkflowExecutionDepends on smartcontractkit/chainlink-protos#298.Used by smartcontractkit/chainlink#21298.