feat: add chip-ingress batch config keys to TOML and wire through#22987
Draft
pkcll wants to merge 1 commit into
Draft
feat: add chip-ingress batch config keys to TOML and wire through#22987pkcll wants to merge 1 commit into
pkcll wants to merge 1 commit into
Conversation
Contributor
|
I see you updated files related to
|
Contributor
|
✅ No conflicts with other open PRs targeting |
|
|
pkcll
force-pushed
the
chip-ingress-batch-config
branch
from
411624f to
e3ae0d9
Compare
Add 7 chip-ingress batch configuration keys to the Telemetry TOML config, the TelemetryConfig interface, and wire them through to beholder.Config and loop.EnvConfig: - ChipIngressBufferSize (default 1000) - ChipIngressMaxBatchSize (default 500) - ChipIngressMaxConcurrentSends (default 10) - ChipIngressSendInterval (default 100ms) - ChipIngressSendTimeout (default 3s) - ChipIngressDrainTimeout (default 10s) - ChipIngressMaxGRPCRequestSize (default 10 MiB) TOML fields use pointer types; accessors return 0 when unset. Defaults are applied via core.toml Default comments and beholder DefaultConfig(). Depends on chainlink-common PR for EnvConfig and beholder.Config changes.
pkcll
force-pushed
the
chip-ingress-batch-config
branch
from
e3ae0d9 to
15564d4
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add 7 chip-ingress batch configuration keys to the Telemetry TOML config, the
TelemetryConfiginterface, and wire them through tobeholder.Config(host path) andloop.EnvConfig(LOOP plugin path):ChipIngressBufferSizeChipIngressMaxBatchSizeChipIngressMaxConcurrentSendsChipIngressSendIntervalChipIngressSendTimeoutChipIngressDrainTimeoutChipIngressMaxGRPCRequestSizeChanges
core/config/toml/types.go: 7 fields onTelemetrystruct +setFrommappingscore/config/telemetry_config.go: 7 accessors onTelemetryinterfacecore/services/chainlink/config_telemetry.go: 7 pass-through implementationscore/cmd/shell.go: 7 fields wired intobeholder.Config(host path)plugins/loop_registry.go: 7 fields wired intoloop.EnvConfig(LOOP path)core/config/docs/core.toml: 7 keys with# Defaultcommentsconfig-full,config-empty-effective,config-multi-chain-effective) updatedgo.mod/go.sum: bumped chainlink-common to include batch config changesDependencies
Depends on chainlink-common PR: smartcontractkit/chainlink-common#2207
Testing
config_telemetry_test.go,loop_registry_test.go,config_test.gogo test ./core/services/chainlink/... ./plugins/... ./core/config/...— all pass (except pre-existing DB-dependent tests requiringCL_DATABASE_URL)