Conversation
|
✅ No conflicts with other open PRs targeting |
|
I see you updated files related to
|
CORA - Pending ReviewersAll codeowners have approved! ✅ Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown For more details, see the full review summary. |
| # to that repo's fake-enclave runner. Check it out at the same revision the | ||
| # plugin is built from so the capability and the enclave app always match. |
There was a problem hiding this comment.
Would it be worth making sure that the two revisions never diverge? Could read it from system-tests/tests/go.mod instead of what is listed as the public plugin.
There was a problem hiding this comment.
We want to use the public plugin sha to build the capability binary, because that is what actually gets used in the chainlink node. The revision used in system-tests/tests/go.mod is what consumes the testhelpers/harness, which is a different go module and is used for a different purpose.
| t.Helper() | ||
|
|
||
| root := os.Getenv("CONFIDENTIAL_COMPUTE_ROOT") | ||
| require.NotEmpty(t, root, |
There was a problem hiding this comment.
Maybe make this a t.Skip instead so it doesn't fail locally for people?
| return fmt.Sprintf("%s://%s:%d%s", incoming.Protocol, host, incoming.ExternalPort, incoming.Path) | ||
| } | ||
|
|
||
| // injectVaultPublicKey writes the vault DON's DKG public key and threshold into |
There was a problem hiding this comment.
Comment looks out of place. Move it to above injectVaultPublicKey.
|
|
||
| // DefaultGatewayWhitelistConfig builds the Gateway Connector's outbound allowlist: | ||
| // the caller's extra ports plus the fake service ports the config declares. Shared | ||
| // by `cre env start` and by tests that call StartCLIEnvironment directly, so both |
There was a problem hiding this comment.
Seems no one one outside this file calls this on this branch, so we could make it private and update the comment to remove saying it is shared "and by tests"
| } | ||
| } | ||
|
|
||
| // UseFakeEnclaveForTest reports whether the harness selected fake enclaves. |
There was a problem hiding this comment.
Nit: Necessity of this one line function is questionable:
UseFakeEnclaveForTest() (helpers.go:360) is a pure one-line wrapper over testhelpers.UseFakeEnclave(), and the test file already calls testhelpers.UseFakeEnclave() directly (test.go:79). Drop the wrapper, call the source in both places.
Co-authored-by: Steve Ellis <email@steveell.is>
…rs.go Co-authored-by: Steve Ellis <email@steveell.is>
| if err != nil { | ||
| return publicKey, errors.Wrap(err, "failed to create request to get workflow keys") | ||
| } | ||
| req.AddCookie(apiClient.Cookies[0]) |
There was a problem hiding this comment.
Unguarded index, could panic.
Co-authored-by: Steve Ellis <email@steveell.is>
|
3 participants
Adds an end-to-end test for confidential workflows, using the enclave test harness from chainlink-confidential-compute.