Skip to content

Add the GitHub CI script for pull request builds - #838

Merged
jonathan343 merged 1 commit into
developfrom
add-pull-request-build
Oct 9, 2026
Merged

jonathan343 merged 1 commit into
developfrom
add-pull-request-build

Conversation

@jonathan343

Copy link
Copy Markdown
Contributor

Summary

smithy-python pull requests currently only run the public CI checks. This PR adds a GitHub Actions workflow that also runs our internal pull request build on every PR against develop, so changes are checked against downstream builds before they merge.

The workflow runs when a PR is opened, updated, or marked ready for review. The job is skipped for draft PRs and for PRs from forks, which can't assume the role. The role session and the step timeout are both 45 minutes. This matches the workflow already used in boto3, botocore, and aws-cli.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jonathan343
jonathan343 marked this pull request as ready for review October 9, 2026 15:21
@jonathan343
jonathan343 requested a review from a team as a code owner October 9, 2026 15:21
@jonathan343
jonathan343 merged commit 71b7fd0 into develop Oct 9, 2026
12 checks passed
@jonathan343
jonathan343 deleted the add-pull-request-build branch October 9, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants