Repository navigation
fix: compare escaped query pairs in generated protocol tests - #383
Merged
Merged
Conversation
Compare serialized query pairs directly, preserving duplicate counts while allowing order differences and additional pairs. Check required and forbidden names in their escaped form. Cover Unicode, escaping, duplicates, ordering, and parameter presence with generated-assertion regression tests.
sichanyoo
approved these changes
Oct 22, 2026
richardwang1124
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Generated protocol specs can fail on JRuby for correctly escaped Unicode query values.
CGI.parsereturns matching bytes with different encoding labels, causing the comparison to fail.This clears the JRuby protocol-test blocker for moving AWS SDK for Ruby V4 to public development.
Fix
Compare escaped query pairs directly, without CGI decoding. Preserve duplicate counts, allow different ordering and additional pairs, and check required or forbidden parameter names.
Testing
Passed on MRI 3.4.9, JRuby 9.4.15, and JRuby 10.0.7:
RestJsonQueryStringEscaping.Zero failures. Existing pending tests unchanged.
Repository-wide RuboCop: 374 files, zero offenses.
git diff --checkpassed.🤖 This PR description was drafted with AI assistance and reviewed by @jterapin. ✨