Use MessagePack for threaded execution channels - #1
Open
samuel-williams-shopify wants to merge 1 commit into
Open
Use MessagePack for threaded execution channels#1samuel-williams-shopify wants to merge 1 commit into
samuel-williams-shopify wants to merge 1 commit into
Conversation
Assisted-By: devx/b8194217-b20a-4799-b266-4910beb3ee2b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use MessagePack for threaded executor channel messages instead of
Marshal. This avoids invoking application-level Marshal serialization while preserving the existing framed transport.A codec boundary is introduced and propagated to both transport endpoints. The MessagePack codec preserves protocol symbols, binary strings, and
Addrinfovalues using registered extension types.The Ractor executor continues to use Marshal for now because MessagePack's native extension is not Ractor-safe.
Validation
bundle exec bake testbundle exec rubocopbundle exec bake decode:index:coverage libgit diff --check