chore: A way to skip checks before publishing, if we know tests already pass#2281
Merged
chore: A way to skip checks before publishing, if we know tests already pass#2281
Conversation
iwoplaza
requested review from
aleksanderkatan,
cieplypolar,
Copilot and
reczkok
|
pkg.pr.new packages benchmark commit |
📊 Bundle Size Comparison
👀 Notable resultsStatic test results:No major changes. Dynamic test results:No major changes. 📋 All resultsClick to reveal the results table (348 entries).
If you wish to run a comparison for other, slower bundlers, run the 'Tree-shake test' from the GitHub Actions menu. |
There was a problem hiding this comment.
Pull request overview
Adds an environment-variable based escape hatch to skip prepublish checks when publishing packages (useful when tests are already known to be green), and documents it in the release checklist.
Changes:
- Introduce
SKIP_ALL_CHECKS=trueas an alternative to the--skip-all-checksflag intgpu-dev-cli prepack. - Reuse a single
skipAllChecksboolean for both publish-tag verification and post-build checks. - Document the new environment variable in
CONTRIBUTING.md.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/tgpu-dev-cli/prepack.mjs | Adds env-var support for skipping checks and wires it into existing gating logic. |
| CONTRIBUTING.md | Documents a publishing tip to skip checks via SKIP_ALL_CHECKS=true. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
iwoplaza
force-pushed
the
chore/skip-checks-env-var
branch
2 times, most recently
from
74484b6 to
d0eb7d8
Compare
Contributor
aleksanderkatan
left a comment
aleksanderkatan
left a comment
There was a problem hiding this comment.
Are we sure we want this? How does our publishing pipeline work, are we running the CI twice?
cieplypolar
approved these changes
Mar 13, 2026
iwoplaza
force-pushed
the
chore/skip-checks-env-var
branch
from
d0eb7d8 to
1367f78
Compare
iwoplaza
force-pushed
the
chore/skip-checks-env-var
branch
from
1367f78 to
cb20bac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.