Open
Conversation
|
pkg.pr.new packages benchmark commit |
📊 Bundle Size Comparison
👀 Notable resultsStatic test results:No major changes. Dynamic test results:No major changes. 📋 All resultsClick to reveal the results table (348 entries).
If you wish to run a comparison for other, slower bundlers, run the 'Tree-shake test' from the GitHub Actions menu. |
There was a problem hiding this comment.
Pull request overview
This PR adjusts TypeGPU’s function type inference so that function “shell” implementations are typed using GPU-visible representations (InferGPU) rather than host representations (Infer), aligning implementation signatures with what the shader codegen expects.
Changes:
- Replace
InferwithInferGPUinTgpuFnShellimplementation typing. - Update
InferArgs,InferImplSchema, andInferIOto infer GPU-side representations.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
packages/typegpu/src/core/function/tgpuFn.ts |
Updates the function shell’s implementation callback typing to return InferGPU<Return>. |
packages/typegpu/src/core/function/fnTypes.ts |
Switches argument/return inference helpers (and InferIO) to use InferGPU consistently. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
iwoplaza
force-pushed
the
fix/fn-infer-gpu
branch
from
31062ee to
0af8426
Compare
iwoplaza
force-pushed
the
fix/fn-infer-gpu
branch
from
0af8426 to
be1b20f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.