Skip to content

fix: add images offset when parsing html #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kacperzolkiewski wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: add images offset when parsing html #340

kacperzolkiewski wants to merge 2 commits into from

Conversation

@kacperzolkiewski
Copy link
Collaborator

@kacperzolkiewski kacperzolkiewski commented Dec 22, 2025

Summary

Fixes: #334

This PR adds offset to tags location (during html parsing) based on number of parsed images from html.

Test Plan

Test case 1:

  1. Use the Set input's value button with the following html containing 5 images:
<html>
<p><img src="https://picsum.photos/id/1/200/200" width="200.000000" height="200.000000"/></p>
<p><img src="https://picsum.photos/id/2/200/200" width="200.000000" height="200.000000"/></p>
<p><img src="https://picsum.photos/id/3/200/200" width="200.000000" height="200.000000"/></p>
<p><img src="https://picsum.photos/id/4/200/200" width="200.000000" height="200.000000"/></p>
<p><img src="https://picsum.photos/id/5/200/200" width="200.000000" height="200.000000"/></p>
</html>

Test Case 2:

  1. Use the Set input's value button with the following html
<html>
<p><img src="https://picsum.photos/id/1/200/200" width="200.000000" height="200.000000"/></p>
<codeblock>xxx</codeblock>
</html>

codeblock should only contain xxx inside it.

Screenshots / Videos

Before:

Screen.Recording.2025-12-22.at.11.56.04.mov

After:

Screen.Recording.2025-12-22.at.11.54.56.mov

Compatibility

OS Implemented
iOS ✅
Android ❌

szydlovsky
szydlovsky reviewed Dec 23, 2025
View reviewed changes
ios/inputParser/InputParser.mm
// the indices for any text following an image are lower than they will be
// in the final NSTextStorage.
//
// We add '_imagesInHtml' to shift the start index forward, aligning this
Copy link
Collaborator

@szydlovsky szydlovsky Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// We add '_imagesInHtml' to shift the start index forward, aligning this
// We add '_precedingImageCount' to shift the start index forward, aligning this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@szydlovsky szydlovsky szydlovsky left review comments

@exploIF exploIF Awaiting requested review from exploIF

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[iOS] Excessive <br> tags when setting value with images.

3 participants

@kacperzolkiewski @szydlovsky