[Native] Fix shouldCancelWhenOutside not tracking the view
#3942
+39
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses the underlying issue of #3906
The original issue described in the above PR was caused by wrong shadow node dimensions, which were fixed by #3930. After that, the dimensions were good, but the long press was still failing. This was caused by
shouldCancelWhenOutsidechecking the dimensions of the detector while the child was moved.This PR changes the logic so that the child's hitbox is checked when using the native detector. This should be enough for iOS, but on Android, further investigation is needed into whether the entire
transformedEventshould be in the coordinate space of the detector or its child.Test plan
See #3906 test plan