Repository navigation
Cap solid-js peer to ^1.8.4 before Solid 2.0 - #77
Merged
Merged
Conversation
The 1.x line peered on solid-js >=1.8.4, which Solid 2.0.0 satisfies. Solid 2 support ships on the next tag. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0117BoWKChs1jT15HHLCEnHn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ryan · project thread
The 1.x line of
@solidjs/metapeers onsolid-js >=1.8.4, whichsolid-js@2.0.0satisfies once stable ships. This caps it to^1.8.4so 1.x users don't get a silent install against Solid 2. Solid 2 support lives on thenexttag (1.0.0-next.x).package.json:"solid-js": ">=1.8.4"→"^1.8.4".changeset/cap-solid-1-peer.md)pnpm install --frozen-lockfilestill passes (the lockfile doesn't record root peers)Release note: npm
latestis still 0.29.4 (May 2024), butmainis already at 0.29.7, so 0.29.5–0.29.7 never published. The Release workflow has no run history left, so the cause isn't visible here; theNPM_TOKENsecret is the likely suspect. Merging this goes through the changesets Version PR and then publishes 0.29.8 only if that publish step works.Generated by Claude Code