chore(ci): add typecheck scripts for local TypeScript verification by Harsh23Kashyap · Pull Request #1438 · sourcebot-dev/sourcebot

Harsh23Kashyap · 2026-07-13T04:20:42Z

Summary

Adds the local tooling half and the CI workflow half of issue #1437, closing the loop.

Root typecheck script in package.json runs tsc --noEmit in every TypeScript workspace via yarn workspaces foreach --all --topological run typecheck.
Per-package typecheck scripts in backend, db, schemas, and shared (each tsc --noEmit).
New .github/workflows/typecheck.yml runs the above on every PR targeting main, parallel to the existing lint.yml and test.yml.

This gives contributors a one-command way to type-check locally (yarn typecheck) AND ensures CI enforces type-check within seconds — instead of waiting for the slow next build inside pr-gate.yml.

Why the web workspace is excluded

packages/web's tsc --noEmit depends on .next/types/**/*.ts (declared in its tsconfig.json include) being generated by next build. Web is already type-checked transitively via the Docker build in pr-gate.yml. Adding a separate tsc --noEmit step for web in this workflow would surface no new errors and would add CI minutes. The matrix excludes web; the remaining 4 workspaces (backend, db, schemas, shared) have no .next-generation dependency and type-check cleanly.

How the workflow ensures fresh types

backend's typecheck depends on shared/dist/env.server.d.ts and db's generated Prisma client. Without those being current, tsc --noEmit reports drift as errors. The workflow runs:

yarn install --frozen-lockfile (initial install).
yarn build:deps — builds schemas, db, shared, query-language in topological order so their dist/ is fresh.
yarn workspace @sourcebot/db prisma:generate — ensures the generated client matches the schema.
yarn workspaces foreach --all --topological --exclude @sourcebot/web run typecheck — invokes tsc --noEmit in each remaining workspace.

The local-tooling side (yarn typecheck) expects the user to have run yarn build:deps and yarn db:generate once after a fresh checkout. The CI workflow does both automatically.

Why this is scoped to backend/db/schemas/shared (not web)

Web already runs tsc via next build in pr-gate.yml's Docker build step. That type-check is real and runs on every PR; what this workflow adds is a fast tsc signal for the other 4 workspaces that previously had no PR-time type-check at all.

Test plan

yarn workspace @sourcebot/{backend,db,schemas,shared} typecheck -> 0 (after yarn db:generate and yarn build:deps)
yarn workspace @sourcebot/web typecheck -> fails as expected (pre-existing .next dependency, out of scope here)
Local workflow YAML structurally valid (parses; references checkout, setup-node, prisma:generate, typecheck, exclude-web)
PR chore(ci): add typecheck scripts for local TypeScript verification #1438 updated with two commits: 457af438 (typecheck scripts) and d95c7e59 (workflow file)
First CI run after PR opens (CodeRabbit + Bugbot will review)

Backward compatibility

None. Pure additive tooling. No source code changes; no new dependencies; one new workflow file.

Risk

CI minutes: adds a new workflow running tsc --noEmit on every PR. Per-workspace typecheck is fast (~5-30s); total run should be under 2 minutes.
First CI run may surface pre-existing latent type errors that have been silently rotting (the same reason this PR is valuable). If errors surface, the maintainer can decide to fix them as a follow-up.

Out of scope

Re-architecting the web tsconfig.json to split build-time types from source types.
Adding tsc --watch for dev mode.
Replacing the existing pr-gate.yml Docker build's type-check step with this workflow's step.

Refs #1437, Closes #1460

coderabbitai · 2026-07-13T04:23:11Z

Walkthrough

Adds no-emit typecheck scripts to all workspaces, a root command for dependency-ordered execution, and a pull-request GitHub Actions workflow that prepares dependencies and runs the checks.

Changes

Workspace typecheck automation

Layer / File(s)	Summary
Workspace scripts and root orchestration `package.json`, `packages/{backend,db,schemas,shared,web}/package.json`	Each workspace adds `tsc --noEmit`, while the root package runs workspace typechecks in topological order.
Pull-request typecheck workflow `.github/workflows/typecheck.yml`	The workflow installs dependencies, builds prerequisite workspaces, generates the Prisma client, and runs ordered typechecks while excluding `@sourcebot/web`.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related issues

chore(ci): add dedicated TypeScript typecheck workflow and root typecheck script #1437 — Covers the workspace TypeScript checks and the associated CI workflow.
chore(ci): add typecheck workflow to wire PR #1438 tooling into CI #1460 — Relates to the workspace scripts and CI workflow added here.

Possibly related PRs

sourcebot-dev/sourcebot#1200 — Uses a similar workspace-coordinated command and GitHub Actions workflow structure for linting.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: adding TypeScript typecheck scripts for verification.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

Harsh23Kashyap · 2026-07-13T04:23:38Z

Can someone take a look when you have a chance?

cursor

Cursor Bugbot has reviewed your changes using high effort and found 3 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 3fcb450. Configure here.}

Harsh23Kashyap · 2026-07-14T15:53:14Z

Can someone take a look when you have a chance?

Harsh23Kashyap · 2026-07-14T20:22:52Z

Can someone take a look when you have a chance?

Harsh23Kashyap · 2026-07-16T14:43:27Z

All three cursor threads resolved (intentional exclusions for db/schemas; no query-language typecheck target yet). CI green. Standing by for a maintainer pass.

Adds a yarn typecheck script in the repository root and per-package typecheck scripts that run tsc --noEmit in each TypeScript workspace (web, backend, db, schemas, shared). Mirrors the existing test/lint conventions: root uses yarn workspaces foreach --all --topological, per-package scripts execute the same TypeScript compiler invocation in isolation. A new .github/workflows/typecheck.yml CI workflow is intentionally NOT added in this commit because running tsc --noEmit on the current main surfaces ~175 latent type errors in the web package (test fixtures referencing schema-drift columns added to migrations 20260702000000 and 20260702000001 but not yet declared in schema.prisma). A follow-up PR will fix the schema-drift, update test fixtures, then add the CI workflow. Mirrors CONTRIBUTING.md 'Developer tooling' / 'Bug fixes' guidance: pure additive tooling, no source code changes, no new dependencies. Refs sourcebot-dev#1437

Harsh23Kashyap · 2026-07-17T11:26:26Z

All three cursor threads resolved (intentional exclusions for db/schemas; no query-language typecheck target yet). CI green. Standing by.

Adds .github/workflows/typecheck.yml that runs `yarn typecheck` on every PR targeting main, parallel to the existing lint.yml and test.yml. The workflow: 1. runs `yarn install --frozen-lockfile` 2. runs `yarn build:deps` so schemas/db/shared/query-language dist files are fresh (downstream workspaces see correct types) 3. runs `yarn workspace @sourcebot/db prisma:generate` so the Prisma client matches the schema 4. runs `yarn workspaces foreach --all --topological --exclude @sourcebot/web run typecheck` to invoke tsc --noEmit in each remaining workspace The web workspace is excluded because its `tsc --noEmit` depends on .next/types/**/*.ts being generated by `next build`. Web is already type-checked transitively via the Docker build in pr-gate.yml. Refs sourcebot-dev#1437

coderabbitai

🧹 Nitpick comments (1)

.github/workflows/typecheck.yml (1)
24-27: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick win

Disable credential persistence in the checkout action.

By default, actions/checkout persists the GitHub token in the local git config. Since this workflow only requires contents: read and does not push changes, explicitly disabling credential persistence improves security hygiene and mitigates potential credential exposure risks (such as the artipacked vulnerability).
🔒️ Proposed fix to disable credential persistence
       - name: Checkout repository
         uses: actions/checkout@v4
         with:
           submodules: "true"
+          persist-credentials: false
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/typecheck.yml around lines 24 - 27, Update the Checkout
repository step using actions/checkout@v4 to disable credential persistence by
setting persist-credentials to false in its with configuration, while preserving
the existing submodules setting.
Source: Linters/SAST tools

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In @.github/workflows/typecheck.yml:
- Around line 24-27: Update the Checkout repository step using
actions/checkout@v4 to disable credential persistence by setting
persist-credentials to false in its with configuration, while preserving the
existing submodules setting.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ef33f27b-7bcd-402f-99cd-724b27790208

📥 Commits

Reviewing files that changed from the base of the PR and between 457af43 and d95c7e5.

📒 Files selected for processing (1)

.github/workflows/typecheck.yml

Harsh23Kashyap changed the title ~~chore(ci): add typecheck scripts~~ chore(ci): add typecheck scripts for local TypeScript verification Jul 13, 2026

Harsh23Kashyap mentioned this pull request Jul 13, 2026

chore(ci): add dedicated TypeScript typecheck workflow and root typecheck script #1437

Open

cursor Bot reviewed Jul 13, 2026

View reviewed changes

Comment thread packages/db/package.json

Comment thread packages/schemas/package.json

Comment thread package.json

Harsh23Kashyap mentioned this pull request Jul 17, 2026

chore(ci): add typecheck workflow to wire PR #1438 tooling into CI #1460

Open

Harsh23Kashyap force-pushed the typecheck-workflow branch from 0f82e6b to 457af43 Compare July 17, 2026 11:21

coderabbitai Bot reviewed Jul 17, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(ci): add typecheck scripts for local TypeScript verification#1438

chore(ci): add typecheck scripts for local TypeScript verification#1438
Harsh23Kashyap wants to merge 2 commits into
sourcebot-dev:mainfrom
Harsh23Kashyap:typecheck-workflow

Harsh23Kashyap commented Jul 13, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jul 13, 2026 •

edited

Loading

Uh oh!

Harsh23Kashyap commented Jul 13, 2026

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Harsh23Kashyap commented Jul 14, 2026

Uh oh!

Harsh23Kashyap commented Jul 14, 2026

Uh oh!

Harsh23Kashyap commented Jul 16, 2026

Uh oh!

Harsh23Kashyap commented Jul 17, 2026

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

Harsh23Kashyap commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Why the web workspace is excluded

How the workflow ensures fresh types

Why this is scoped to backend/db/schemas/shared (not web)

Test plan

Backward compatibility

Risk

Out of scope

Uh oh!

coderabbitai Bot commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

Harsh23Kashyap commented Jul 13, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Harsh23Kashyap commented Jul 14, 2026

Uh oh!

Harsh23Kashyap commented Jul 14, 2026

Uh oh!

Harsh23Kashyap commented Jul 16, 2026

Uh oh!

Harsh23Kashyap commented Jul 17, 2026

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Harsh23Kashyap commented Jul 13, 2026 •

edited

Loading

coderabbitai Bot commented Jul 13, 2026 •

edited

Loading