Emit implementation relationships for remote type -> local interface#198
Open
Emit implementation relationships for remote type -> local interface#198
Conversation
jupblb
force-pushed
the
michal/remote-local-interface
branch
4 times, most recently
from
ba12ea5 to
578d2d0
Compare
jupblb
force-pushed
the
michal/remote-local-interface
branch
from
578d2d0 to
81c04b8
Compare
Enable findImplementations for remote types against local interfaces, emitting the resulting SymbolInformation entries as external symbols in the SCIP index. This allows the backend to discover when dependency types implement interfaces defined in the indexed project. Fixes #64
Add formatExternalSymbols to scip_test.go that emits an external_symbols.txt file when the index contains external symbols. This makes the remote type -> local interface relationships visible and verifiable in snapshot output.
Replace manual document iteration and custom formatExternalSymbols with testutil.FormatSnapshots from scip, which handles both document formatting and external symbol rendering.
jupblb
force-pushed
the
michal/remote-local-interface
branch
from
81c04b8 to
d736433
Compare
jupblb
force-pushed
the
michal/remote-local-interface
branch
from
6c4d245 to
b9819cc
Compare
…matches Replace Close() error with ScipTestMethod() so the embedded implementation test doesn't pull in dozens of stdlib types that vary across OS/arch. The pr198 test still covers external symbol emission with a controlled dependency.
jupblb
force-pushed
the
michal/remote-local-interface
branch
2 times, most recently
from
52afe3f to
cd6d3d4
Compare
jupblb
force-pushed
the
michal/remote-local-interface
branch
from
cd6d3d4 to
ff9fa40
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable
findImplementationsfor remote types against local interfaces, emitting the resultingSymbolInformationentries as external symbols in the SCIP index. This allows the backend to discover when dependency types implement interfaces defined in the indexed project.This solution was recommended at #64 (comment).
DO NOT MERGE before scip-code/scip#390 is merged and released.
Fixes #64