Repository navigation
npm: drop unused dependencies - #1397
Open
marcleblanc2 wants to merge 1 commit into
Open
marcleblanc2 wants to merge 1 commit into
marcleblanc2 wants to merge 1 commit into
Conversation
marcleblanc2
changed the title
The overrides block was added in #1218 and #1219 to force patched versions of cross-spawn, glob, and brace-expansion, which tar 7.1 pulled in through rimraf. tar 7.5 (#1319, #1357) dropped rimraf, so none of those packages are in the dependency tree anymore and the overrides have no effect. Renovate still reads them as declared dependencies and keeps opening PRs to bump them (#1389, #1390, #1392, #1393). @types/tar is unused: npm-distribution has no TypeScript, and tar 7 ships its own types (#1391 would have replaced it with a deprecated stub). Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-01a1a37e-8603-775d-bc85-c5677817f7a8
marcleblanc2
force-pushed
the
marc/npm-drop-stale-overrides
branch
from
November 4, 2026 00:30
2c695b2 to
94f09e2
Compare
marcleblanc2
changed the base branch from
main
to
marc/ci-release-artifact-checks
November 4, 2026 00:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
npm-distribution/package.jsonincludes old unneeded, and should be tidiedRenovate also opens unnecessary PRs to update them
Solution
Remove the
overridesblockcross-spawn,glob, andbrace-expansion, whichtar7.1 pulled in throughrimraftar7.5 (chore/security: update deps for CVEs reported by trivy #1319, chore/deps: bump vulnerable dependencies ahead of 7.6.0 release #1357) droppedrimraf, so none of those packages are in the lockfile anymore and the overrides are no longer effectiveRemove
@types/tarnpm-distribution/has no TypeScript (three.jsfiles), andtar7 ships its own typesRegenerated
package-lock.jsonvianpm install --package-lock-onlyOnce merged, Renovate should close the five PRs above on its own since the packages are no longer declared
Test plan
npm cifrom the new lockfile,npm auditreports 0 vulnerabilities,require("tar")loadsAmp thread
https://ampcode.com/threads/T-01a1a37e-8603-775d-bc85-c5677817f7a8