Skip to content

Fix false negative on required with properties and not#2288

Merged
jviotti merged 2 commits intomainfrom
not-properties
Mar 6, 2026
Merged

Fix false negative on required with properties and not#2288
jviotti merged 2 commits intomainfrom
not-properties

Conversation

@jviotti
Copy link
Member

@jviotti jviotti commented Mar 6, 2026

See: sourcemeta/studio#173
Signed-off-by: Juan Cruz Viotti jv@jviotti.com

See: sourcemeta/studio#173
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

@augmentcode
Copy link

augmentcode bot commented Mar 6, 2026

🤖 Augment PR Summary

Summary: This PR fixes a lint false-negative/incorrect outcome around required when properties are defined higher up but required appears under nested applicators involving not.

Changes:

  • Update `required_properties_in_properties` to walk up the schema frame through “in-place” applicator keywords (e.g., `oneOf`/`not`) when resolving whether a `required` entry is covered by a `properties` definition.
  • Stop the walk when crossing a non in-place applicator boundary (e.g., `items`) to avoid incorrectly inheriting `properties` from a different instance location.
  • Add regression tests covering `oneOf` + `required` + `not` (should be clean) and `items` + `not` + `required` (should still lint).

Technical Notes: The ancestor walk is constrained to applicator keyword types that validate the same instance location, preventing leakage of properties across instance-boundary applicators.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti jviotti merged commit 73fd7cd into main Mar 6, 2026
13 checks passed
@jviotti jviotti deleted the not-properties branch March 6, 2026 13:46
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/llvm)

Details
Benchmark suite Current: 3a83af0 Previous: ac96b5f Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 3.1203547703031074 ns/iter 3.5209819215341085 ns/iter 0.89
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 3.1287268348686395 ns/iter 3.5201514150513544 ns/iter 0.89
Regex_Period_Asterisk 3.110630394159772 ns/iter 3.518904086783206 ns/iter 0.88
Regex_Group_Period_Asterisk_Group 3.1101134775889574 ns/iter 3.5187387608116563 ns/iter 0.88
Regex_Period_Plus 3.1152489683146767 ns/iter 3.5220239272247187 ns/iter 0.88
Regex_Period 3.116837249890012 ns/iter 3.525996464097755 ns/iter 0.88
Regex_Caret_Period_Plus_Dollar 3.1135688551791745 ns/iter 3.87123259584587 ns/iter 0.80
Regex_Caret_Group_Period_Plus_Group_Dollar 3.115222643808211 ns/iter 3.521286920747552 ns/iter 0.88
Regex_Caret_Period_Asterisk_Dollar 3.1098302696243048 ns/iter 3.507127989593115 ns/iter 0.89
Regex_Caret_Group_Period_Asterisk_Group_Dollar 3.113453896426446 ns/iter 3.518074733278576 ns/iter 0.88
Regex_Caret_X_Hyphen 12.44231892815612 ns/iter 12.315860729619155 ns/iter 1.01
Regex_Period_Md_Dollar 27.207248921695736 ns/iter 26.713377899819207 ns/iter 1.02
Regex_Caret_Slash_Period_Asterisk 6.2302230206485625 ns/iter 7.3878777941482365 ns/iter 0.84
Regex_Caret_Period_Range_Dollar 3.7500694211760335 ns/iter 3.520357009298922 ns/iter 1.07
Regex_Nested_Backtrack 49.218693178878986 ns/iter 47.2153599130123 ns/iter 1.04
JSON_Array_Of_Objects_Unique 436.9624995444673 ns/iter 444.6308339695059 ns/iter 0.98
JSON_Parse_1 6144.472353328802 ns/iter 6030.940802256267 ns/iter 1.02
JSON_Parse_Real 10983.429912478874 ns/iter 10516.980193479572 ns/iter 1.04
JSON_Parse_Decimal 11106.83537513034 ns/iter 11334.52231731301 ns/iter 0.98
JSON_Parse_Schema_ISO_Language 3612954.871134216 ns/iter 3652257.593749653 ns/iter 0.99
JSON_Fast_Hash_Helm_Chart_Lock 61.98486685699087 ns/iter 75.96628263879722 ns/iter 0.82
JSON_Equality_Helm_Chart_Lock 161.50235938938422 ns/iter 161.2206435885274 ns/iter 1.00
JSON_Divisible_By_Decimal 597.8415429887099 ns/iter 526.538492064962 ns/iter 1.14
JSON_String_Equal/10 6.250749313294299 ns/iter 5.982852190339448 ns/iter 1.04
JSON_String_Equal/100 6.853710906464597 ns/iter 6.707029098985284 ns/iter 1.02
JSON_String_Equal_Small_By_Perfect_Hash/10 0.9364612344309866 ns/iter 1.0558284186510543 ns/iter 0.89
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 14.797734485767133 ns/iter 12.501372056900422 ns/iter 1.18
JSON_String_Fast_Hash/10 2.494467235970553 ns/iter 2.467830248099083 ns/iter 1.01
JSON_String_Fast_Hash/100 2.4933085044990695 ns/iter 2.4639660673726573 ns/iter 1.01
JSON_String_Key_Hash/10 2.6746416695430715 ns/iter 2.463452953387606 ns/iter 1.09
JSON_String_Key_Hash/100 9.033267815174092 ns/iter 8.092036774572541 ns/iter 1.12
JSON_Object_Defines_Miss_Same_Length 3.7404686254259554 ns/iter 4.223720823079739 ns/iter 0.89
JSON_Object_Defines_Miss_Too_Small 3.749111766136762 ns/iter 4.22511611193603 ns/iter 0.89
JSON_Object_Defines_Miss_Too_Large 3.7420646729915648 ns/iter 4.22443454375726 ns/iter 0.89
Pointer_Object_Traverse 27.289438780728755 ns/iter 30.11773211012694 ns/iter 0.91
Pointer_Object_Try_Traverse 28.193211278664663 ns/iter 29.51053936514139 ns/iter 0.96
Pointer_Push_Back_Pointer_To_Weak_Pointer 205.3707811205743 ns/iter 195.3994371275461 ns/iter 1.05
Pointer_Walker_Schema_ISO_Language 2997208.802575355 ns/iter 3183968.122727327 ns/iter 0.94
Schema_Frame_WoT_References 4791084.97931034 ns/iter 5002145.971222895 ns/iter 0.96
Schema_Frame_OMC_References 19827420.400000457 ns/iter 20869935.272726666 ns/iter 0.95
Schema_Frame_OMC_Locations 18185106.894739084 ns/iter 19337851.666667424 ns/iter 0.94
Schema_Frame_ISO_Language_Locations 96776883.16666414 ns/iter 99578937.33333851 ns/iter 0.97
Schema_Frame_KrakenD_References 36984015.15789316 ns/iter 39570170.166667946 ns/iter 0.93
Schema_Frame_KrakenD_Reachable 556170549.9999335 ns/iter 599567631.0000136 ns/iter 0.93
Schema_Iterator_ISO_Language 2221313.650793779 ns/iter 2230511.6158728804 ns/iter 1.00
Schema_Frame_ISO_Language_Locations_To_JSON 131014531.74999733 ns/iter 136294467.99998847 ns/iter 0.96
Schema_Tracker_ISO_Language 26619513.153845605 ns/iter 27114427.222222228 ns/iter 0.98
Schema_Tracker_ISO_Language_To_JSON 22023457.545453146 ns/iter 22065034.968751006 ns/iter 1.00
Schema_Format_ISO_Language_To_JSON 102404546.14284186 ns/iter 105780158.14287159 ns/iter 0.97
Schema_Bundle_Meta_2020_12 1553511.86888538 ns/iter 1596617.2840930684 ns/iter 0.97
Schema_Frame_Many_Resources_References 348926367.5000416 ns/iter 359820135.5000015 ns/iter 0.97
Alterschema_Check_Readibility_ISO_Language_Set_3 205630536.3333498 ns/iter 199993327.6666752 ns/iter 1.03
Alterschema_Check_Readibility_OMC 31566820.714282412 ns/iter 32931176.38095499 ns/iter 0.96
Alterschema_Apply_Readibility_KrakenD 574293142.9999771 ns/iter 570799910.0000051 ns/iter 1.01
EditorSchema_ForEditor_EmbeddedResources 13422127.865370525 ns/iter 13812811.745096684 ns/iter 0.97
URITemplateRouter_Create 17020.390457103826 ns/iter 14854.2633063933 ns/iter 1.15
URITemplateRouter_Match 177.08929177464032 ns/iter 167.79583239908658 ns/iter 1.06
URITemplateRouterView_Restore 6808.201695606026 ns/iter 8813.202824607502 ns/iter 0.77
URITemplateRouterView_Match 152.61882979105405 ns/iter 147.57262219314373 ns/iter 1.03

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (macos/llvm)

Details
Benchmark suite Current: 3a83af0 Previous: ac96b5f Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 2.1614025045929384 ns/iter 2.610954205542569 ns/iter 0.83
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 2.5216385997411885 ns/iter 2.734908394890192 ns/iter 0.92
Regex_Period_Asterisk 2.16361311224373 ns/iter 2.776974287131518 ns/iter 0.78
Regex_Group_Period_Asterisk_Group 2.0275393699542286 ns/iter 2.4641233483492653 ns/iter 0.82
Regex_Period_Plus 2.481714821012605 ns/iter 2.8039312491229538 ns/iter 0.89
Regex_Period 2.2981917860494434 ns/iter 2.820606198750449 ns/iter 0.81
Regex_Caret_Period_Plus_Dollar 2.286150346301713 ns/iter 3.145611872810958 ns/iter 0.73
Regex_Caret_Group_Period_Plus_Group_Dollar 2.2103130275850402 ns/iter 3.1419380629178577 ns/iter 0.70
Regex_Caret_Period_Asterisk_Dollar 1.7768400375616162 ns/iter 2.42891660642565 ns/iter 0.73
Regex_Caret_Group_Period_Asterisk_Group_Dollar 1.8085290041494646 ns/iter 2.473461891948659 ns/iter 0.73
Regex_Caret_X_Hyphen 6.593542076959226 ns/iter 8.940602112412524 ns/iter 0.74
Regex_Period_Md_Dollar 20.335205109977935 ns/iter 33.586132535541836 ns/iter 0.61
Regex_Caret_Slash_Period_Asterisk 4.849719571825385 ns/iter 6.783289200794103 ns/iter 0.71
Regex_Caret_Period_Range_Dollar 1.7988022196261626 ns/iter 2.6605963019395062 ns/iter 0.68
Regex_Nested_Backtrack 26.49593249218005 ns/iter 38.524474664700385 ns/iter 0.69
JSON_Array_Of_Objects_Unique 372.1699691317321 ns/iter 560.5808902167811 ns/iter 0.66
JSON_Parse_1 4474.241009388218 ns/iter 7198.266634507618 ns/iter 0.62
JSON_Parse_Real 6723.009589644517 ns/iter 9708.24594719749 ns/iter 0.69
JSON_Parse_Decimal 8350.183432775237 ns/iter 12312.437823683882 ns/iter 0.68
JSON_Parse_Schema_ISO_Language 3575832.9330144366 ns/iter 5875844.036696736 ns/iter 0.61
JSON_Fast_Hash_Helm_Chart_Lock 60.37369211444693 ns/iter 82.7564849229373 ns/iter 0.73
JSON_Equality_Helm_Chart_Lock 139.10885324477442 ns/iter 207.57034796279544 ns/iter 0.67
JSON_Divisible_By_Decimal 458.03541682485786 ns/iter 627.4996863377015 ns/iter 0.73
JSON_String_Equal/10 6.957812085519359 ns/iter 9.694489975100138 ns/iter 0.72
JSON_String_Equal/100 6.749471654973524 ns/iter 9.909422981320427 ns/iter 0.68
JSON_String_Equal_Small_By_Perfect_Hash/10 0.7827247217471999 ns/iter 1.1897105319935313 ns/iter 0.66
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 3.448150053131222 ns/iter 5.484983749997809 ns/iter 0.63
JSON_String_Fast_Hash/10 2.4384482397421974 ns/iter 3.1007247144324697 ns/iter 0.79
JSON_String_Fast_Hash/100 2.055875061418526 ns/iter 2.663088803179988 ns/iter 0.77
JSON_String_Key_Hash/10 1.365212092647197 ns/iter 2.0403870320995323 ns/iter 0.67
JSON_String_Key_Hash/100 2.1707228442926816 ns/iter 3.607954837538553 ns/iter 0.60
JSON_Object_Defines_Miss_Same_Length 2.5643803934078617 ns/iter 3.5000045102906805 ns/iter 0.73
JSON_Object_Defines_Miss_Too_Small 2.4291485408707425 ns/iter 3.3703832419414685 ns/iter 0.72
JSON_Object_Defines_Miss_Too_Large 2.4346205370507494 ns/iter 3.0779619180163786 ns/iter 0.79
Pointer_Object_Traverse 15.021286590667845 ns/iter 20.57979427163914 ns/iter 0.73
Pointer_Object_Try_Traverse 20.22873343507934 ns/iter 27.14300361297903 ns/iter 0.75
Pointer_Push_Back_Pointer_To_Weak_Pointer 158.7275047890689 ns/iter 219.2805632018061 ns/iter 0.72
Pointer_Walker_Schema_ISO_Language 4887839.364779874 ns/iter 5666704.899081739 ns/iter 0.86
Schema_Frame_WoT_References 5125279.625000089 ns/iter 8649104.976743622 ns/iter 0.59
Schema_Frame_OMC_References 25903741.96153369 ns/iter 36719125.000001356 ns/iter 0.71
Schema_Frame_OMC_Locations 22030298.387093235 ns/iter 33239155.782617357 ns/iter 0.66
Schema_Frame_ISO_Language_Locations 79286031.25000677 ns/iter 103352654.71430181 ns/iter 0.77
Schema_Frame_KrakenD_References 44047713.56249171 ns/iter 63577656.25000411 ns/iter 0.69
Schema_Frame_KrakenD_Reachable 396254625.0000969 ns/iter 612100958.9999175 ns/iter 0.65
Schema_Iterator_ISO_Language 1872649.6203211802 ns/iter 2298927.989130149 ns/iter 0.81
Schema_Frame_ISO_Language_Locations_To_JSON 89101234.3749935 ns/iter 122724608.19999652 ns/iter 0.73
Schema_Tracker_ISO_Language 30917418.478259645 ns/iter 38214524.47058458 ns/iter 0.81
Schema_Tracker_ISO_Language_To_JSON 16716770.839998389 ns/iter 20050486.91428653 ns/iter 0.83
Schema_Format_ISO_Language_To_JSON 86966353.99999763 ns/iter 105210041.6666614 ns/iter 0.83
Schema_Bundle_Meta_2020_12 1267337.1444474536 ns/iter 1761415.2563579655 ns/iter 0.72
Schema_Frame_Many_Resources_References 293208604.00002855 ns/iter 407788979.4999692 ns/iter 0.72
Alterschema_Check_Readibility_ISO_Language_Set_3 177620174.99999276 ns/iter 210003055.66659942 ns/iter 0.85
Alterschema_Check_Readibility_OMC 33719620.850001775 ns/iter 45295365.38460049 ns/iter 0.74
Alterschema_Apply_Readibility_KrakenD 450208937.4998377 ns/iter 613398792.0002255 ns/iter 0.73
EditorSchema_ForEditor_EmbeddedResources 10678013.91305047 ns/iter 14542966.720009644 ns/iter 0.73
URITemplateRouter_Create 17239.565125699337 ns/iter 19610.075215656416 ns/iter 0.88
URITemplateRouter_Match 167.92790164960812 ns/iter 200.70774514853602 ns/iter 0.84
URITemplateRouterView_Restore 14544.131820149776 ns/iter 16969.964835535535 ns/iter 0.86
URITemplateRouterView_Match 129.81207735647385 ns/iter 177.10056168586308 ns/iter 0.73

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (windows/msvc)

Details
Benchmark suite Current: 3a83af0 Previous: ac96b5f Ratio
Regex_Lower_S_Or_Upper_S_Asterisk 4.127095498440792 ns/iter 4.122897194862042 ns/iter 1.00
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 4.111756471379817 ns/iter 4.095471837670043 ns/iter 1.00
Regex_Period_Asterisk 4.745982599879615 ns/iter 4.717956037316939 ns/iter 1.01
Regex_Group_Period_Asterisk_Group 4.433350624999832 ns/iter 4.399071874999549 ns/iter 1.01
Regex_Period_Plus 4.417121649814075 ns/iter 4.450919341750044 ns/iter 0.99
Regex_Period 4.4207063819556 ns/iter 4.4229331249994175 ns/iter 1.00
Regex_Caret_Period_Plus_Dollar 4.116212074055495 ns/iter 4.108386292808535 ns/iter 1.00
Regex_Caret_Group_Period_Plus_Group_Dollar 3.795310171794008 ns/iter 3.78528749324002 ns/iter 1.00
Regex_Caret_Period_Asterisk_Dollar 4.485778750000691 ns/iter 4.4183637499997985 ns/iter 1.02
Regex_Caret_Group_Period_Asterisk_Group_Dollar 4.100920230537411 ns/iter 4.088262641228721 ns/iter 1.00
Regex_Caret_X_Hyphen 7.576239955357421 ns/iter 7.551064732140844 ns/iter 1.00
Regex_Period_Md_Dollar 36.4708051155501 ns/iter 35.45450680397824 ns/iter 1.03
Regex_Caret_Slash_Period_Asterisk 7.28595424107224 ns/iter 7.233053571429338 ns/iter 1.01
Regex_Caret_Period_Range_Dollar 4.119055810927534 ns/iter 4.104091301970764 ns/iter 1.00
Regex_Nested_Backtrack 99.61721876708387 ns/iter 93.00836638356841 ns/iter 1.07
JSON_Array_Of_Objects_Unique 467.21052440778163 ns/iter 460.42569140379055 ns/iter 1.01
JSON_Parse_1 9085.676403229563 ns/iter 8809.906652203163 ns/iter 1.03
JSON_Parse_Real 16491.88392857326 ns/iter 16426.984555697258 ns/iter 1.00
JSON_Parse_Decimal 15428.213266904546 ns/iter 15150.815621359588 ns/iter 1.02
JSON_Parse_Schema_ISO_Language 5948966.071429141 ns/iter 5901887.50000006 ns/iter 1.01
JSON_Fast_Hash_Helm_Chart_Lock 55.6614399999944 ns/iter 52.50943750001267 ns/iter 1.06
JSON_Equality_Helm_Chart_Lock 258.74907142857796 ns/iter 258.6496785714384 ns/iter 1.00
JSON_Divisible_By_Decimal 1151.8018750003023 ns/iter 1223.8944642855847 ns/iter 0.94
JSON_String_Equal/10 12.293258928569426 ns/iter 12.266189285713024 ns/iter 1.00
JSON_String_Equal/100 12.934375000002417 ns/iter 12.893212500001384 ns/iter 1.00
JSON_String_Equal_Small_By_Perfect_Hash/10 1.8886824124005055 ns/iter 1.8812793766798472 ns/iter 1.00
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 12.613378124999741 ns/iter 12.853992857141552 ns/iter 0.98
JSON_String_Fast_Hash/10 3.168907973701708 ns/iter 3.139525892857518 ns/iter 1.01
JSON_String_Fast_Hash/100 3.161709821428969 ns/iter 3.1574517857139637 ns/iter 1.00
JSON_String_Key_Hash/10 4.130075052019124 ns/iter 4.089631123373603 ns/iter 1.01
JSON_String_Key_Hash/100 16.637188058230997 ns/iter 14.371915114411898 ns/iter 1.16
JSON_Object_Defines_Miss_Same_Length 3.78579588609759 ns/iter 3.7785819575376456 ns/iter 1.00
JSON_Object_Defines_Miss_Too_Small 3.7907639508930453 ns/iter 3.78197321428456 ns/iter 1.00
JSON_Object_Defines_Miss_Too_Large 5.045096999999714 ns/iter 5.038820535712521 ns/iter 1.00
Pointer_Object_Traverse 41.49244374998773 ns/iter 42.85303689423455 ns/iter 0.97
Pointer_Object_Try_Traverse 56.61340178570689 ns/iter 55.628517857136174 ns/iter 1.02
Pointer_Push_Back_Pointer_To_Weak_Pointer 170.51372058158924 ns/iter 164.70922308321875 ns/iter 1.04
Pointer_Walker_Schema_ISO_Language 11478180.357142622 ns/iter 11797991.071428474 ns/iter 0.97
Schema_Frame_WoT_References 10246466.666667402 ns/iter 10568646.874997256 ns/iter 0.97
Schema_Frame_OMC_References 41688035.294114076 ns/iter 43620479.99999656 ns/iter 0.96
Schema_Frame_OMC_Locations 39228238.88889424 ns/iter 41781958.82353547 ns/iter 0.94
Schema_Frame_ISO_Language_Locations 195068900.00002384 ns/iter 204791866.66671014 ns/iter 0.95
Schema_Frame_KrakenD_References 87920788.88887368 ns/iter 93563985.71428923 ns/iter 0.94
Schema_Frame_KrakenD_Reachable 521701399.99998355 ns/iter 565389499.9998101 ns/iter 0.92
Schema_Iterator_ISO_Language 4240896.987951886 ns/iter 4378218.749999974 ns/iter 0.97
Schema_Frame_ISO_Language_Locations_To_JSON 256066266.6666455 ns/iter 265416066.6666788 ns/iter 0.96
Schema_Tracker_ISO_Language 45939673.33333542 ns/iter 48314671.42857296 ns/iter 0.95
Schema_Tracker_ISO_Language_To_JSON 52926363.63635046 ns/iter 54248881.818177156 ns/iter 0.98
Schema_Format_ISO_Language_To_JSON 200478133.33326304 ns/iter 209316699.9998933 ns/iter 0.96
Schema_Bundle_Meta_2020_12 2719603.214282123 ns/iter 3227585.9848458352 ns/iter 0.84
Schema_Frame_Many_Resources_References 1510351100.0002072 ns/iter 1566390199.999887 ns/iter 0.96
Alterschema_Check_Readibility_ISO_Language_Set_3 320870950.00008506 ns/iter 344968600.0000156 ns/iter 0.93
Alterschema_Check_Readibility_OMC 58587981.818184495 ns/iter 64786963.63635869 ns/iter 0.90
Alterschema_Apply_Readibility_KrakenD 984662799.9997964 ns/iter 1084495699.999934 ns/iter 0.91
EditorSchema_ForEditor_EmbeddedResources 27079461.538479473 ns/iter 28751383.33334348 ns/iter 0.94
URITemplateRouter_Create 23086.459375001312 ns/iter 22774.17551143517 ns/iter 1.01
URITemplateRouter_Match 207.3248322622868 ns/iter 227.90296874994453 ns/iter 0.91
URITemplateRouterView_Restore 32320.80240891768 ns/iter 31249.192077693828 ns/iter 1.03
URITemplateRouterView_Match 154.8930580357068 ns/iter 160.5251562499989 ns/iter 0.96

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark (linux/gcc)

Details
Benchmark suite Current: 3a83af0 Previous: ac96b5f Ratio
URITemplateRouter_Create 11435.239082523969 ns/iter 14359.85258732546 ns/iter 0.80
URITemplateRouter_Match 150.32230387705778 ns/iter 176.89601545474306 ns/iter 0.85
URITemplateRouterView_Restore 2408.0070125351936 ns/iter 8803.585140405788 ns/iter 0.27
URITemplateRouterView_Match 114.66554876528163 ns/iter 127.03490720183144 ns/iter 0.90
EditorSchema_ForEditor_EmbeddedResources 12323441.403495645 ns/iter 14480079.265328584 ns/iter 0.85
Alterschema_Check_Readibility_ISO_Language_Set_3 182685668.7499685 ns/iter 201710461.666759 ns/iter 0.91
Alterschema_Check_Readibility_OMC 32122112.136366095 ns/iter 34746909.849991426 ns/iter 0.92
Alterschema_Apply_Readibility_KrakenD 557211792.0000892 ns/iter 583317674.0002272 ns/iter 0.96
Schema_Frame_WoT_References 4664540.700000543 ns/iter 5383618.31538448 ns/iter 0.87
Schema_Frame_OMC_References 19889217.44444699 ns/iter 23341495.77418723 ns/iter 0.85
Schema_Frame_OMC_Locations 18491462.564101405 ns/iter 21256605.69696596 ns/iter 0.87
Schema_Frame_ISO_Language_Locations 98249725.85715841 ns/iter 103071138.83330506 ns/iter 0.95
Schema_Frame_KrakenD_References 38684980.88888827 ns/iter 41264060.5882456 ns/iter 0.94
Schema_Frame_KrakenD_Reachable 826627925.9999009 ns/iter 612483701.0002011 ns/iter 1.35
Schema_Iterator_ISO_Language 2411961.271477172 ns/iter 2393840.709898351 ns/iter 1.01
Schema_Frame_ISO_Language_Locations_To_JSON 212753423.7499731 ns/iter 271292747.6666967 ns/iter 0.78
Schema_Tracker_ISO_Language 28218587.759993173 ns/iter 32098951.82609888 ns/iter 0.88
Schema_Tracker_ISO_Language_To_JSON 29928519.91304791 ns/iter 29785961.260882765 ns/iter 1.00
Schema_Format_ISO_Language_To_JSON 102840058.57150598 ns/iter 107585845.00003313 ns/iter 0.96
Schema_Bundle_Meta_2020_12 1618378.3901927148 ns/iter 1740176.504981221 ns/iter 0.93
Schema_Frame_Many_Resources_References 368466068.9999646 ns/iter 390049391.00004774 ns/iter 0.94
Pointer_Object_Traverse 26.67995932836248 ns/iter 27.758904956463585 ns/iter 0.96
Pointer_Object_Try_Traverse 26.77324359052837 ns/iter 33.76413679653362 ns/iter 0.79
Pointer_Push_Back_Pointer_To_Weak_Pointer 172.0969522148244 ns/iter 179.0567843132516 ns/iter 0.96
Pointer_Walker_Schema_ISO_Language 3270893.3738323674 ns/iter 3498817.469698215 ns/iter 0.93
JSON_Array_Of_Objects_Unique 317.72053302773935 ns/iter 419.28954956168553 ns/iter 0.76
JSON_Parse_1 7255.55838694095 ns/iter 8384.99460761276 ns/iter 0.87
JSON_Parse_Real 11008.25564217733 ns/iter 12269.675521289162 ns/iter 0.90
JSON_Parse_Decimal 14799.100445156238 ns/iter 16912.728777064807 ns/iter 0.88
JSON_Parse_Schema_ISO_Language 4248211.357575697 ns/iter 4867910.576387481 ns/iter 0.87
JSON_Fast_Hash_Helm_Chart_Lock 47.41777925294047 ns/iter 52.97318692066332 ns/iter 0.90
JSON_Equality_Helm_Chart_Lock 138.63049373196887 ns/iter 184.2683378904794 ns/iter 0.75
JSON_Divisible_By_Decimal 537.9951968086614 ns/iter 495.75591110030734 ns/iter 1.09
JSON_String_Equal/10 5.876174996673907 ns/iter 6.419086118600606 ns/iter 0.92
JSON_String_Equal/100 7.0203243288843415 ns/iter 7.131079983240589 ns/iter 0.98
JSON_String_Equal_Small_By_Perfect_Hash/10 0.8263728006445804 ns/iter 0.7103768030568829 ns/iter 1.16
JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10 21.888234732060887 ns/iter 28.93102308227536 ns/iter 0.76
JSON_String_Fast_Hash/10 1.1528358328192256 ns/iter 1.4083523040736023 ns/iter 0.82
JSON_String_Fast_Hash/100 1.1531013347171755 ns/iter 1.4119283728520724 ns/iter 0.82
JSON_String_Key_Hash/10 1.7291141143735198 ns/iter 1.0643473571317974 ns/iter 1.62
JSON_String_Key_Hash/100 11.830567300528733 ns/iter 14.824838887284372 ns/iter 0.80
JSON_Object_Defines_Miss_Same_Length 3.4764619394533085 ns/iter 3.518028190652737 ns/iter 0.99
JSON_Object_Defines_Miss_Too_Small 3.5197058195905275 ns/iter 3.893764156013362 ns/iter 0.90
JSON_Object_Defines_Miss_Too_Large 3.6310242312437917 ns/iter 3.8727134628253888 ns/iter 0.94
Regex_Lower_S_Or_Upper_S_Asterisk 1.4418382559521048 ns/iter 1.4087229163055188 ns/iter 1.02
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar 1.7286169351739844 ns/iter 1.4083122753911126 ns/iter 1.23
Regex_Period_Asterisk 1.7295733540885194 ns/iter 1.4078329210697078 ns/iter 1.23
Regex_Group_Period_Asterisk_Group 1.7276375230344696 ns/iter 1.4081102963886245 ns/iter 1.23
Regex_Period_Plus 1.729041788205775 ns/iter 1.408399715630449 ns/iter 1.23
Regex_Period 1.7287666368040993 ns/iter 1.4080880910089655 ns/iter 1.23
Regex_Caret_Period_Plus_Dollar 1.729665324627015 ns/iter 1.4079089399554399 ns/iter 1.23
Regex_Caret_Group_Period_Plus_Group_Dollar 1.4409736484357523 ns/iter 1.7610102164905548 ns/iter 0.82
Regex_Caret_Period_Asterisk_Dollar 1.4410508733857652 ns/iter 1.7596565497343544 ns/iter 0.82
Regex_Caret_Group_Period_Asterisk_Group_Dollar 1.4411852004103298 ns/iter 1.4131899990288586 ns/iter 1.02
Regex_Caret_X_Hyphen 8.35118570451368 ns/iter 11.606076796533454 ns/iter 0.72
Regex_Period_Md_Dollar 23.930873289306508 ns/iter 33.874547053347186 ns/iter 0.71
Regex_Caret_Slash_Period_Asterisk 8.108940756477907 ns/iter 4.577425550076201 ns/iter 1.77
Regex_Caret_Period_Range_Dollar 1.4404308795513716 ns/iter 1.7604918122391038 ns/iter 0.82
Regex_Nested_Backtrack 44.16659897736506 ns/iter 54.510693243124614 ns/iter 0.81

This comment was automatically generated by workflow using github-action-benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant