Skip to content

Add additional URI parsing failure tests #2289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jviotti merged 1 commit into from
Mar 9, 2026
Merged

Add additional URI parsing failure tests #2289

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions test/uri/uri_parse_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,18 @@ TEST(URI_parse, syntax_error_percent_in_host) {
sourcemeta::core::URIParseError);
}

// RFC 3986: fragment = *( pchar / "/" / "?" )
TEST(URI_parse, syntax_error_double_fragment_delimiter) {
EXPECT_THROW(sourcemeta::core::URI uri{"http://example.com/#frag#ment"},
sourcemeta::core::URIParseError);
}

// RFC 3986: "[" and "]" are gen-delims only allowed in IP-literal within host.
TEST(URI_parse, syntax_error_brackets_in_query) {
EXPECT_THROW(sourcemeta::core::URI uri{"http://example.com/?q=[value]"},
sourcemeta::core::URIParseError);
}

// RFC 3986: relative-ref path-noscheme means the first segment of a
// schemeless, authorityless path must not contain a colon
TEST(URI_parse, syntax_error_digit_prefix_scheme_like) {
Expand Down