Repository navigation
Allow calling each, each_hash without block - #656
Merged
Merged
Conversation
kch
changed the title
flavorjones
reviewed
Nov 29, 2025
flavorjones
left a comment
flavorjones
left a comment
Member
There was a problem hiding this comment.
Thanks for opening this PR! This is a nice quality-of-life improvement. I have just a couple of comments about the test coverage (which I have been trying to improve with every PR).
flavorjones
reviewed
Nov 29, 2025
flavorjones
reviewed
Nov 29, 2025
Member
|
Sorry for the delay here, I've got a large open-source backlog at the moment and plan to get back to this shortly. |
flavorjones
force-pushed
the
each_hash_enum
branch
from
February 26, 2026 14:05
d9798a9 to
5127f03
Compare
flavorjones
force-pushed
the
each_hash_enum
branch
from
October 10, 2026 21:05
5127f03 to
150c9cb
Compare
Assert identity with `assert_same`, since `ResultSet` does not define `==`. Drop the `reset` calls, which the identity assertion makes redundant, and the `each_hash` case added to `test_result_set.rb`, which `test_each_hash_enum` covers.
Member
|
Thanks, @kch. I pushed two commits to this branch:
|
flavorjones
enabled auto-merge (squash)
October 13, 2026 21:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Returns an enumerator. Matching similar methods in ruby stdlib.