Move channel field into root of AddTranscript#138
Merged
J-Jaywalker merged 2 commits intomasterfrom Aug 13, 2025
Merged
Conversation
Contributor
Author
|
Would this need a release tag to get put into Aladdin? |
dumitrugutu
approved these changes
Aug 13, 2025
Contributor
Yes, and since it's a potentially a breaking change it should be released with major version bump |
Co-authored-by: Dumitru Gutu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apologies for being back at it again.
When testing multichannel internally, I noticed that many people instinctively looked for the
channelfield within the root or metadata of theAddTranscriptmessage. Right now,channelis in both the results and metadata object. This change will mean the Python client will look for it in just the root of the message.Accompanying change for this can be found in GitLab:
https://gitlab1.speechmatics.io/aml/aladdin/-/merge_requests/10861
Have tested the changes against the branch above, rough local testing with 5 channels transcribing the same audio file.
Without:
With new changes: