Open
Conversation
|
|
TiboStev
force-pushed
the
add_visitUnknows_capability
branch
from
4f9eec8 to
33dec6a
Compare
|
There have been a few PRs related to the idea of tracking unknown fags. Can you explain why you chose this approach over #199? |
Author
|
I didn't see #199, I fell that using flags and VisitUnknowns() may fit better the API and make it more elegant if one needs to iterate over unknown flags. But in the end I just need a way to retrieve unknown flags so one way or another I'm fine with it. |
3 tasks
|
@TiboStev Made a version of this on my fork. Feel free to check it out 😃 |
Author
|
thanks for the review @cornfeedhobo I'll have a look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make able to use unknown flag and make it accessible for future use. For a wrapper for example