Repository navigation
testquality: the allowlist key is the package's, and held by a test - #15
Merged
Merged
Conversation
What a finding's key is - the package without go/packages' " [p.test]" and "_test", and the test's name - is the line every repository's allowlist is written in, and it lived in main, which has no tests: a change to either strip would have made every entry of spin's list unexplained and stale at once with nothing here failing. Findings is the package's now, and a module under testdata holds the key for a test in the package, beside it, and behind each of the two build tags. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The allowlist key - the package without go/packages'
[p.test]and_test, plus the test's name - is the line spin'shack/testquality-allow.txt(and spin-pr-gotools') is written in. It lived incmd/testquality/main.go, which has no tests. It isinternal/testquality.FindingsandFinding.Keynow, held by a module under testdata: a test in the package, beside it (pkg_test), and behindintegrationande2e.Output and exit codes unchanged: old and new binaries compared byte for byte on the fixture module (with and without an allowlist holding a stale entry) and on spin with its allowlist.
task test,task lint: greentask mutate: 5 refused, 0 survived🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.