Skip to content

versions: Validate, Newest and Resolve are this module's own - #16

Merged
aledbf merged 2 commits into
mainfrom
versions/unexport-unused
Sep 29, 2026
Merged

aledbf merged 2 commits into
mainfrom
versions/unexport-unused

Conversation

@aledbf

@aledbf aledbf commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Entry.Validate, upstream.Newest and upstream.Resolve have no caller outside this module: spin, spin-ami, spin-machine, shipset and spin-pr-gotools were vetted (go vet ./... with -tags=integration,e2e) against this tree through a go.work, all clean (spin-pr-gotools stops only on its unbuilt web/dist embed). Each export was a promise to five repositories that nobody held. Status.Newest stays: cmd/versions prints it.

The rename puts newest, resolve, validate, Check and Set whole in the mutation gate, and 27 of their edits had no test that refused them. The second commit holds them, with no network: a local git repository (lightweight and annotated tags, a branch), a docker stand-in on PATH, and httptest servers.

  • resolve: a git pin is the commit (an annotated tag peeled, a branch's head), a download's is the sum at the version asked, an image's is docker's digest; each failure is an error.

  • newest: tags, branch, commit, the github-release track's own repository, a pypi name that is no URL, an unknown track.

  • Check: 11 entries covering current, behind by version, behind at the same version, a commit-tracked file at head / moved / unreadable, a git entry by commit, follows, unknown.

  • validate: a download's https + {version} source, a module's package path.

  • Set's [2]string → [3]string is exempt: nothing reads past kv[1].

  • task test (coverage 62.8% → 66.7%), task lint: green

  • task mutate: 71 refused, 0 survived

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

aledbf and others added 2 commits September 29, 2026 09:53
No repository that takes go-tools calls them - spin, spin-ami, spin-machine,
shipset and spin-pr-gotools vet against this tree through a go.work - and
each export is a promise to all five that nobody holds. Parse and Set still
validate, Bump and Check still resolve, and Status.Newest stays: cmd/versions
prints it.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@aledbf
aledbf force-pushed the versions/unexport-unused branch from 06e0971 to 578d20f Compare September 29, 2026 12:53
@aledbf
aledbf merged commit d73ecb8 into main Sep 29, 2026
2 checks passed
@aledbf
aledbf deleted the versions/unexport-unused branch September 29, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant