Repository navigation
allow: the ratchet is split in one place - #17
Merged
Merged
Conversation
internal/allow says it exists so refs and testquality read their lists alike, and each still split its findings on its own: refs behind an Allow type that held a map and prefixed an error, testquality inline. Split is allow's now, generic over the finding and its key, and refs.Allow is gone. The why of the stale half moves with it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
internal/allowexists so refs and testquality read their allowlists alike, and each still split findings against it on its own: refs behindrefs.Allow(a map, aLen, and arefs:error prefixcmd/refscan add itself), testquality inline inmain.allow.Split[T](allowed, found, key)replaces both andallow.Stale;internal/refs/allow.gois gone. The comment on why the stale half matters moves toSplit, and the<file><TAB><reference>spelling torefs.Finding.Key.Output and exit codes unchanged: old and new
refscompared on spin withhack/refs-allow.txt, with a stale entry added, and with a missing list; old and newtestqualityon a fixture module with a stale entry.task test,task lint: greentask mutate: nothing to break outsidecmd/(Split's sites are index reads and!, which the tool does not edit);TestSplitIsWhatNothingExplainsAndWhatExplainsNothingholds both halves and their order🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.