Repository navigation
Align Parquet page-index and checksum defaults across writers - #25
Merged
Merged
Conversation
Signed-off-by: Martin Prammer <martin@spiraldb.com>
Signed-off-by: Martin Prammer <martin@spiraldb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up on #23 by making supported defaults explicit: parquet-java enables page checksums, and arrow-rs enables page indexes when statistics are on. Disabling statistics now also disables the arrow-rs OffsetIndex, matching pyarrow.
Verify defaults and explicit overrides against files from all four writers, and run that suite in the sidecar CI jobs. Arrow-rs still cannot write checksums; Hardwood still cannot write indexes.
Type of change
🤖 Generated with Codex.