Open
Conversation
Co-authored-by: Emiliano Sanchez <emiliano.sanchez@harness.io>
| @@ -53,10 +53,7 @@ export class OpenFeatureSplitProvider implements Provider { | |||
| providerName: this.metadata.name, | |||
| ...(updateMetadata | |||
| ? { | |||
Contributor
There was a problem hiding this comment.
Shouldn't this be simplified as follows?
providerName: this.metadata.name,
...(updateMetadata
? {
metadata: { type: updateMetadata.type },
flagsChanged: updateMetadata.names || []
}
: {}),
to have an empty flagsChanged if metadata type is 'SEGMENTS_UPDATE'
| @@ -1,3 +1,7 @@ | |||
| 1.3.0 (February 12, 2026) | |||
| - ConfigurationChanged event now forwards SDK_UPDATE metadata from Split (flagsChanged, metadata with type and names) | |||
Contributor
There was a problem hiding this comment.
I would use the convention - Updated ...
something like, - Updated ConfigurationChanged event to forward SDK_UPDATE ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains