feat: ADDON-87374 Split FOSSA license and vulnerability checks in reusable release workflow#503
Open
nayanak-896 wants to merge 25 commits into
Open
feat: ADDON-87374 Split FOSSA license and vulnerability checks in reusable release workflow#503nayanak-896 wants to merge 25 commits into
nayanak-896 wants to merge 25 commits into
Conversation
### Description - Appinspect CLI action bump to v2.11 - Java version for pre-commit updated - don't require GSSA execution for docs only changes. ### Checklist - [x] `README.md` has been updated or is not required - [ ] push trigger tests - [ ] manual release test - [ ] automated releases test - [ ] pull request trigger tests - [ ] schedule trigger tests - [ ] workflow errors/warnings reviewed and addressed ### Testing done splunk/splunk-add-on-for-microsoft-office-365#932 splunk/splunk-add-on-for-okta-identity-cloud#420
### Description Build job for certain TAs requires newer Java. ### Checklist - [ ] `README.md` has been updated or is not required - [ ] push trigger tests - [ ] manual release test - [ ] automated releases test - [ ] pull request trigger tests - [ ] schedule trigger tests - [ ] workflow errors/warnings reviewed and addressed ### Testing done https://github.com/splunk/splunk-dbx-add-on-for-weaviate/actions/runs/23184277927
### Description Update the GSSA image version to 1.2 to replace the deprecated Claude 3.6. The new GSSA image now uses Claude 4.6 by defualt. ### Checklist - [ ] `README.md` has been updated or is not required - [ ] push trigger tests - [ ] manual release test - [ ] automated releases test - [x] pull request trigger tests - [ ] schedule trigger tests - [ ] workflow errors/warnings reviewed and addressed ### Testing done https://github.com/splunk/splunk-add-on-for-salesforce/actions/runs/25112929634/job/73592285875?pr=853 ### Description (PR description goes here) ### Checklist - [ ] `README.md` has been updated or is not required - [ ] push trigger tests - [ ] manual release test - [ ] automated releases test - [ ] pull request trigger tests - [ ] schedule trigger tests - [ ] workflow errors/warnings reviewed and addressed ### Testing done (for each selected checkbox, the corresponding test results link should be listed here)
### Description Release v5.4.0 Notes: feat: adding support spl2 integration tests fix: bump gssa version ### Checklist - [ ] `README.md` has been updated or is not required - [ ] push trigger tests - [ ] manual release test - [ ] automated releases test - [ ] pull request trigger tests - [ ] schedule trigger tests - [ ] workflow errors/warnings reviewed and addressed ### Testing done (for each selected checkbox, the corresponding test results link should be listed here) --------- Co-authored-by: mkolasinski-splunk <105011638+mkolasinski-splunk@users.noreply.github.com> Co-authored-by: Dariusz Karas <dkaras@splunk.com> Co-authored-by: Dariusz Karas <78362586+dkaras-splunk@users.noreply.github.com>
### Description fix: shorter job name https://github.com/splunk/splunk-add-on-for-palo-alto-networks/actions/runs/26407104971 ### Checklist - [ ] `README.md` has been updated or is not required - [ ] push trigger tests - [ ] manual release test - [ ] automated releases test - [ ] pull request trigger tests - [ ] schedule trigger tests - [ ] workflow errors/warnings reviewed and addressed ### Testing done (for each selected checkbox, the corresponding test results link should be listed here)
### Description (PR description goes here) ### Checklist - [ ] `README.md` has been updated or is not required - [ ] push trigger tests - [ ] manual release test - [ ] automated releases test - [ ] pull request trigger tests - [ ] schedule trigger tests - [ ] workflow errors/warnings reviewed and addressed ### Testing done (for each selected checkbox, the corresponding test results link should be listed here)
### Description drop ubuntu:16.04 from scripted input tests (EOL) ### Checklist - [ ] `README.md` has been updated or is not required - [ ] push trigger tests - [ ] manual release test - [ ] automated releases test - [ ] pull request trigger tests - [ ] schedule trigger tests - [ ] workflow errors/warnings reviewed and addressed ### Testing done (for each selected checkbox, the corresponding test results link should be listed here)
### Description -n paralel execution for spl2 tests (PR description goes here) ### Checklist - [ ] `README.md` has been updated or is not required - [ ] push trigger tests - [ ] manual release test - [ ] automated releases test - [ ] pull request trigger tests - [ ] schedule trigger tests - [ ] workflow errors/warnings reviewed and addressed ### Testing done (for each selected checkbox, the corresponding test results link should be listed here)
--ignore_additional_fields_in_actual --ignore_empty_strings ### Description (PR description goes here) ### Checklist - [ ] `README.md` has been updated or is not required - [ ] push trigger tests - [ ] manual release test - [ ] automated releases test - [ ] pull request trigger tests - [ ] schedule trigger tests - [ ] workflow errors/warnings reviewed and addressed ### Testing done (for each selected checkbox, the corresponding test results link should be listed here)
### Description fix: add missing secret ### Checklist - [ ] `README.md` has been updated or is not required - [ ] push trigger tests - [ ] manual release test - [ ] automated releases test - [ ] pull request trigger tests - [ ] schedule trigger tests - [ ] workflow errors/warnings reviewed and addressed ### Testing done (for each selected checkbox, the corresponding test results link should be listed here)
) ## Summary The PAT → GitHub App migration in #484 rewrites private-repo clones via: ``` git config --global --add url."https://${TOKEN}@github.com".insteadOf https://github.com git config --global --add url."https://${TOKEN}@github.com".insteadOf ssh://git@github.com ``` That worked for PATs (GitHub accepts a PAT as the *username*), but **GitHub App installation tokens require the literal username `x-access-token`**. With only `<TOKEN>@github.com`, git treats the token as the username, GitHub returns 401, and git falls back to a non-interactive password prompt: ``` fatal: could not read Password for 'https://***@github.com': No such device or address exit code: 128 ``` This is currently breaking downstream add-ons that install private \`git+ssh\` dependencies (e.g. \`splunk/psa-cim-models\`) during the reusable workflow's \`run-unit-tests\` step. Example failing run: <https://github.com/splunk/splunk-add-on-for-microsoft-cloud-services/actions/runs/27150540186/job/80206858148>. ## Fix Prefix the rewritten URL with \`x-access-token:\` in all three jobs that perform the rewrite: - \`run-unit-tests\` - \`build\` - \`run-ucc-modinput-functional-tests\` (setup-poetry) ```diff - git config --global --add url."https://${{ steps.app-token.outputs.token }}@github.com".insteadOf https://github.com - git config --global --add url."https://${{ steps.app-token.outputs.token }}@github.com".insteadOf ssh://git@github.com + git config --global --add url."https://x-access-token:${{ steps.app-token.outputs.token }}@github.com".insteadOf https://github.com + git config --global --add url."https://x-access-token:${{ steps.app-token.outputs.token }}@github.com".insteadOf ssh://git@github.com ``` Targeting \`main\` so it can ship as a \`v5.5.x\` patch (matches the path taken by #495/#496/#497/#500). ## Note on App scope (not part of this PR) Even with this fix, the GitHub App identified by \`GH_APP_CLIENT_ID\` / \`GH_APP_PRIVATE_KEY\` must be installed on the private dependency repo (e.g. \`splunk/psa-cim-models\`) with \`contents: read\`. Otherwise the clone will now fail with a clearer 403/404 instead of the password-prompt error. The \`create-github-app-token\` call only specifies \`owner: \${{ github.repository_owner }}\`, so it inherits whatever repos the App is installed on in the org. ## Checklist - [ ] \`README.md\` has been updated or is not required - [x] push trigger tests - [ ] manual release test - [ ] automated releases test - [x] pull request trigger tests - [ ] schedule trigger tests - [x] workflow errors/warnings reviewed and addressed ## Testing done To verify after merge & v5.5.x tag: re-run the failing \`splunk-add-on-for-microsoft-cloud-services\` pipeline pinned to the new tag and confirm \`run-unit-tests\` clones \`splunk/psa-cim-models\` successfully. Made with [Cursor](https://cursor.com) Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the reusable add-on build-test-release workflow to split FOSSA findings into separate license and vulnerability checks, improve release gating, and document the new workflow behavior.
JIRA Link - https://splunk.atlassian.net/browse/ADDON-87374
Changes
fossa-license-testfossa-vulnerability-testfossa-license-issuesfossa-vulnerability-issuespre-publishrelease gating so release paths can block independently on:fossa-testbehavior while split results are available.Checklist
README.mdhas been updatedTested TA GitHub Actions run: