Update benchmark charts to use unit sizes #355
+101
−76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark ResultBenchmark diff with base branchBenchmark result |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the benchmark chart outputs to report normalized sizes (bytes per metric datapoint / bytes per trace span) instead of total bytes, improving comparability across datasets.
Changes:
- Normalize metric size charts to
Bytes/pointand trace size charts toBytes/span(with 1-decimal rounding). - Add a shared float rounding helper and adjust chart recording to preserve non-integer values.
- Keep speed benchmark charts as integer
ns/pointvalues by rounding at call sites.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| docs/benchmarks.html | Regenerated benchmark charts with per-point/per-span y-axis units and normalized values. |
| benchmarks/size_test.go | Computes point/span counts and records normalized chart values; updates chart axis units. |
| benchmarks/charts.go | Adds roundFloat helper and stops forcing integer rounding in Record. |
| benchmarks/benchmarks_test.go | Rounds Record-based speed metrics now that Record no longer rounds internally. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Instead of showing total byte sizes charts now show bytes per datapoint or per span, which is easier to compare for different datasets.
tigrannajaryan
force-pushed
the
tigran/chars-bytes-per-point
branch
from
a8c532d to
7f9d4dc
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of showing total byte sizes charts now show bytes per datapoint or per span, which is easier to compare for different datasets.