Open
Conversation
Contributor
|
Hi @G-haoyu Good idea, and similar to what we do in the typescript version, but I think there are some changes to this implementation that would better fix the issue you are trying to solve
|
|
Any updates on this? |
patoAloco
approved these changes
Dec 16, 2024
patoAloco
approved these changes
Dec 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using basic-pitch for audio to midi, for longer audio, the prediction consumes more memory resources, which may cause Tensorflow to kill the predict process.
By slicing the audio and splitting the prediction into slices, and then combining them into a complete prediction result, memory resource consumption is greatly reduced. It is more suitable for basic-pitch to be promoted and used.