Allow specifying the charset to use in ExchangeFilterFunctions#basicAuthentication#36777
Open
kzander91 wants to merge 1 commit into
Open
Allow specifying the charset to use in ExchangeFilterFunctions#basicAuthentication#36777kzander91 wants to merge 1 commit into
ExchangeFilterFunctions#basicAuthentication#36777kzander91 wants to merge 1 commit into
Conversation
kzander91
force-pushed
the
basic-auth-charset
branch
2 times, most recently
from
5e02412 to
414a955
Compare
spring-projects-issues
added
the
status: waiting-for-triage
kzander91
force-pushed
the
basic-auth-charset
branch
3 times, most recently
from
778a8a4 to
d9b1843
Compare
sbrannen
added
the
in: web
Member
|
Indeed, |
…uthentication. Signed-off-by: Kai Zander <61500114+kzander91@users.noreply.github.com>
kzander91
force-pushed
the
basic-auth-charset
branch
from
d9b1843 to
d14e6a6
Compare
Contributor
Author
|
@sbrannen I just noticed that the new |
sbrannen
added
type: enhancement
Member
We actually decided to include this in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for specifying the charset to use for encoding the credentials in
ExchangeFilterFunctions#basicAuthentication.I recently noticed that the existing method uses ISO-8859-1 to encode the credentials. In my app, this caused authentication failures when calling an API protected by Spring Security with a password that contains multi-byte characters. Spring Security uses UTF-8 by default to decode the credentials (see https://github.com/spring-projects/spring-security/blob/ee35c2c9ccd9f57d279d6bdef61d21c750bef15e/web/src/main/java/org/springframework/security/web/authentication/www/BasicAuthenticationConverter.java#L49).