Repository navigation
Fix busy-spin in OutputStreamPublisher await() - #37657
Open
L00PLeGeNd wants to merge 1 commit into
Open
L00PLeGeNd wants to merge 1 commit into
L00PLeGeNd wants to merge 1 commit into
Conversation
Same failure mode as spring-projects#37159 in SubscriberInputStream: after interrupt or spurious wakeup, parkedThread kept the writer reference so the CAS never parked again and the loop spun. Park while the reference is still ours, and on interrupt restore the flag, clear the reference, and throw InterruptedIOException. Applies to both spring-core and spring-web copies. Fixes spring-projects#37621 Signed-off-by: Yinghuai Fu <328742512@qq.com>
spring-projects-issues
added
the
status: waiting-for-triage
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Same busy-spin as #37159, but in
OutputStreamPublisher.await()(both thespring-coreandspring-webcopies).After
park()returns without aresume()(interrupt or spurious wakeup),parkedThreadstill held the writer. Later CAS attempts failed, so the loop neither parked nor exited and burned CPU until more demand arrived or the subscription was cancelled.Apply the same fix as
SubscriberInputStream:InterruptedIOExceptionRelated
Fixes #37621
Checklist