GH-1703 - Simplify JPA publication status defaulting#1704
Open
char-yb wants to merge 1 commit into
Open
Conversation
Remove an unreachable completionDate check from the constructor's default status assignment. Signed-off-by: char-yb <uiurihappy@naver.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
statusassignment inJpaEventPublication.completionDatecheck from the constructor.Details
JpaEventPublicationpreviously initializedstatuswith:However, completionDate is an instance field, not a constructor parameter. During constructor execution it still has its default value, null, so the Status.COMPLETED branch is not reachable from this expression.
This change keeps the effective behavior and makes the defaulting logic explicit: