Skip to content

tests(oidc) :: pin auth cookie attributes in test - #1424

Merged
lovasoa merged 1 commit into
sqlpage:mainfrom
81reap:mutation/08-test-auth-cookie
Sep 6, 2026
Merged

tests(oidc) :: pin auth cookie attributes in test#1424
lovasoa merged 1 commit into
sqlpage:mainfrom
81reap:mutation/08-test-auth-cookie

Conversation

@81reap

@81reap 81reap commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

set_auth_cookie sets sqlpage_auth with Secure, HttpOnly, SameSite=Lax and
path=/. No test checks any of them. test_oidc_happy_path runs the whole login flow,
but it only checks that the callback redirects and that the next request returns 200.

The test now reads sqlpage_auth from the callback's Set-Cookie headers and asserts
all four attributes.

@81reap
81reap marked this pull request as ready for review September 2, 2026 02:42
@lovasoa
lovasoa marked this pull request as draft September 2, 2026 21:25
@lovasoa

lovasoa commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

empty description = draft

@81reap

81reap commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator Author

this is it, there's nothing more. the PR title is self descriptive. its just improving gaps in testing that was found by #1396. This would have gone with #1423 but following the ask in #1412 I've broken this out into a separate PR since it doesn't really help #1423

@81reap
81reap marked this pull request as ready for review September 2, 2026 21:38
@lovasoa
lovasoa marked this pull request as draft September 2, 2026 21:50
@81reap
81reap marked this pull request as ready for review September 2, 2026 23:03
Comment thread tests/oidc/mod.rs Outdated
@lovasoa lovasoa changed the title fix(oidc) :: pin auth cookie attributes in test tests(oidc) :: pin auth cookie attributes in test Sep 3, 2026
@81reap
81reap force-pushed the mutation/08-test-auth-cookie branch from 91f3256 to ef479e8 Compare September 6, 2026 06:11
@81reap
81reap requested a review from lovasoa September 6, 2026 07:06
@lovasoa
lovasoa merged commit fd69d4b into sqlpage:main Sep 6, 2026
51 checks passed
@81reap
81reap deleted the mutation/08-test-auth-cookie branch September 7, 2026 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants