Skip to content

feat(triggers): add start and end modifiers#115

Merged
Rushaway merged 11 commits intosrcdslab:masterfrom
Dolly132:main-dolly1
Mar 26, 2026
Merged

feat(triggers): add start and end modifiers#115
Rushaway merged 11 commits intosrcdslab:masterfrom
Dolly132:main-dolly1

Conversation

@Dolly132
Copy link
Contributor

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for trimming voice-trigger audio playback by introducing Start and End modifiers, wiring those modifiers through command parsing into FFmpeg (-ss / -t) so only a portion of the clip is played.

Changes:

  • Extend AudioClip.Play() / FFmpegAudioPlayer.PlayURI() with a duration argument and pass it to ffmpeg via -t.
  • Parse Start/End modifiers from chat input and compute a playback duration in the trigger command handler.
  • Update an existing AudioClip.Play(...) call site (DECTalk) to account for the new positional parameter.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/torchlight/FFmpegAudioPlayer.py Adds duration handling and emits -t in the ffmpeg command line.
src/torchlight/AudioClip.py Extends Play() to forward duration to the underlying audio player.
src/torchlight/AudioManager.py Updates param parsing to recognize Start/End and caches AudioParams config.
src/torchlight/Commands.py Computes start/duration from modifiers and updates a call site for the new Play() signature.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Rushaway Rushaway merged commit a3ccd40 into srcdslab:master Mar 26, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants