Conversation
✅ Deploy Preview for stackable-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
sbernauer
previously approved these changes
Sep 30, 2025
sbernauer
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
maltesander
reviewed
Sep 30, 2025
Member
|
IMO the extremly personal style of this text damages clarity and simplicity. I mean formulations like "our products", "your Kubernetes resources" are pretty vague and don't read very professional. Also there is a bit of callout inflation, like for example:
As a reader I have to wonder: as opposed to what? I know this is a a bit of style preference so I don't expect you to agree. |
adwk67
reviewed
Sep 30, 2025
Techassi
reviewed
Oct 1, 2025
Member
Author
|
I believe I have fixed all comments and also tried to address some of the feedback from @razvan. |
Co-authored-by: Andrew Kenworthy <1712947+adwk67@users.noreply.github.com>
Techassi
previously approved these changes
Oct 10, 2025
Member
Techassi
left a comment
Techassi
left a comment
There was a problem hiding this comment.
LGTM, just one minor suggestion.
Co-authored-by: Techassi <git@techassi.dev>
adwk67
approved these changes
Oct 10, 2025
lfrancke
moved this from Development: In Review
to Development: Done
in Stackable Engineering
xeniape
pushed a commit
that referenced
this pull request
Oct 13, 2025
* Rework the Lifecycle policies page * Address review feedback * Update modules/ROOT/pages/policies.adoc Co-authored-by: Andrew Kenworthy <1712947+adwk67@users.noreply.github.com> * Update modules/ROOT/pages/policies.adoc Co-authored-by: Techassi <git@techassi.dev> --------- Co-authored-by: Andrew Kenworthy <1712947+adwk67@users.noreply.github.com> Co-authored-by: Techassi <git@techassi.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.